Re: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in io_uring_mmap

Pavel Begunkov
2025-02-21T17:05:10Z

On 2/21/25 16:39, Jens Axboe wrote:
> On 2/21/25 5:20 AM, Pavel Begunkov wrote:
>> On 2/21/25 09:10, lizetao wrote:
>>> Hi,
>>>
>>>> -----Original Message-----
>>>> From: Bui Quang Minh <minhquangbui99@gmail.com>
>>>> Sent: Friday, February 21, 2025 5:00 PM
>>>> To: io-uring@vger.kernel.org
>>>> Cc: Jens Axboe <axboe@kernel.dk>; Pavel Begunkov
>>>> <asml.silence@gmail.com>; David Wei <dw@davidwei.uk>; linux-
>>>> kernel@vger.kernel.org; Bui Quang Minh <minhquangbui99@gmail.com>
>>>> Subject: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in
>>>> io_uring_mmap
>>>>
>>>> Allow user to mmap the kernel allocated zerocopy-rx refill queue.
>>>>
>>>
>>> Maybe fixed-tag should be added here.
>>
>> No need, it's not strictly a fix, and whlist it's not yet sent to
>> linus, the tags only cause confusion when hashes change, e.g. on rebase.
>
> I do like using fixes still, if only to provide a link to the original
> commit without needing to dig for it. And yeah there's the occasional
> rebase where I forget to update the sha, but those get discovered pretty
> quick.

Maybe a "Link" tag would be better or some more inconsequential
"Refers-to", but otherwise you can call it a feature and avoid the
hassle of fixing it up, and people getting spammed by tooling,
and Stephen having to write about broken hashes.

--
Pavel Begunkov