From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B54A29BDA9 for ; Mon, 22 Dec 2025 15:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766417200; cv=none; b=SfcWRS68mGNnk1D+BzHr3AgCRxVc0gK5xgUam7UFVUdsGF0cG/TFAt/9J2msB5KfEm2eCwpal7sWQuzDEFQAlKUXDHJxWLndmN9ZF8TzsW4foWWzfkTxuUHaqUGMmzWB1p1RsO+Gg4fug5MBnbaHEOZbq+tG9HdMJWb7n1J9h3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766417200; c=relaxed/simple; bh=ByAK3B7z3X6qWCj/LiTDvSBIx4+8HJOErZYxV96j+Dc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=b51X6pC6mUK8yCvQfHrtInN8d0sLKpqjr5ajwiIacmW/fjhK70LrJqIbLwMUb3gqw0rR5ufKX1fMQgC66ya/v3Yf58rCvbfptcDmw2kI3DGOadXHhIPqdocYwmO5nQUqunWA4eoTubzeIGs8wVwePMR8mRDDsZI6s+meO+7X8jA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ItNCt0Sn; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qeIP2hLV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ItNCt0Sn"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qeIP2hLV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766417198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rhK/BZ52bTZ5S9PsrmmSG9r64dXYBxuciN4xfBSZQtE=; b=ItNCt0SnioYfQWwCL2BwBYpu1pl8zlOBLYs+PvbpkWQhDtvvwm9ewop6UytbSuOPfHJzj5 LHt0yPvgfZv7HBT2OavkYAR67RnuGfxd2F/1eHWrE5MO3prkip7p5GlZicXGPXQQP5Wbac UpNQ5A6EK8AeQ1yMyJGFrD1N2gKsj34= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-ZM7qBEQyOhOEunNfsP1xSw-1; Mon, 22 Dec 2025 10:26:36 -0500 X-MC-Unique: ZM7qBEQyOhOEunNfsP1xSw-1 X-Mimecast-MFC-AGG-ID: ZM7qBEQyOhOEunNfsP1xSw_1766417195 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-430f57cd2caso4101278f8f.0 for ; Mon, 22 Dec 2025 07:26:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766417195; x=1767021995; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=rhK/BZ52bTZ5S9PsrmmSG9r64dXYBxuciN4xfBSZQtE=; b=qeIP2hLVNmNr9O2MEtI6NyIB8TLta051kEe+laNio6jSsVHIWQRUht0rnkt0YFvuep aoGRegN1troXCZ15npwXOMk5WycSo39KXpjTEyHMSDnAxDLFaNNZyAaBDikAYnBHXcJO Eq39Y88AlkRODTBUdGGq+gBCnb1t+7xH4WovB6LNKTOelm1+PSpZEE663MxmoI2by4NI o1wK4ZNxBVWT+N2JSjz6imbxBV/N7vY0Q1U8CqxZSNwOY6X34GjzhJB+G+EQxVZ4pBFj gVeRO+pw+msovO4RNLovTFXuBJ1g7t0BxlT/BoR4boD4lREOe4LrQLOJA+u+BRHjeCDM ppxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766417195; x=1767021995; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rhK/BZ52bTZ5S9PsrmmSG9r64dXYBxuciN4xfBSZQtE=; b=FbMM0SWk2+GOTXNPtdQxdHSy92ZhYITUC53FvjL9HENcdppOj6EqvU6lobe0vr3aqf Pqf8Iv9RdjMRDMZCEYM1zllij8nM5fd+QHPmZ0yqgHUf8X8wFs3Qg+RlJH40uauf1FGI XjOQuTjtOsBiZ0z6AqNY8k4TTJRm6BWMwJbdX0o/VICH188o8GZp2NzPJVDLgm39lb0i 6Lk3BqvuAoudIq1lU3bJjtUKA/IVMpZsovQNQXt/URJANEVrlWTMTPDvSP2BlSuVkjlk frhluvX9SwS47iMCQzkWqPR781EnWhBipdXDKE7YiRH/hy0kbf+vgSE5o679sG9CBVg7 ZLjQ== X-Forwarded-Encrypted: i=1; AJvYcCWUGB7NyZezlhBBt891v8v4NQaEWOGr7iGbMbxJnscQHOQMWnItfQGMuDmWrU/4H5w8wj074EajVOw5Dbk=@vger.kernel.org X-Gm-Message-State: AOJu0YwzUF+SlnrCisQQtOGQuRM6uC383nsyYs2B1gzD+m2S/dGemUmG PB8BsCKs15kIqJoJ/KvV6muNDG52vBAwQLAq52UIgcL5dXb/sTyKjkuZye48IhSZoTPVYKGYJ3J dMtPuX5693gqFCcV+6FNoFF9a1Me7ozJHnojYu4fj2u1jwABe2C+PDO8/ZZLAyQwCQSRMOM2KlQ Iz X-Gm-Gg: AY/fxX4JLr0gCCRkYfFfwbFl2s2ovXlL/IC5juCKmla/sP4ITk7g3/CqXFe2fb7lC7m YB4gz1kkHxbSKOF5QtLNaoAJd4BIpTNrrNZ95Msb0lWzkq+9AhBAgqrupqpmChVitHWSZ7++Mn0 lHo7kvAzqik830npmxWWceXvHLz5q2NmAzyIyKgRST5sEYiYdtI12M/bwnNmkSA6ILgxwszjBQx YhKXchpCzWJojWgVMfEqrxB/jDw5xXLN/hVB65nLG9XFtt8qU0jZ1npiE05Ob9WpTVqz3KvuDwm mi5t0+TVZYk8nOs6j1MX71rDG5UbfDGQToJR10ela27LVXUfvs2BHWHEOdyRUYvetLU7REUNPIy 6RpObhcHahtEZZ2l5pP9yGrqLlPUMQj9+Ov6YepV8K4nBLyHiuS79FTl2NfCWS7mWPrYNu/lWZJ jjcnocw//H X-Received: by 2002:a05:6000:402a:b0:430:f41f:bd5d with SMTP id ffacd0b85a97d-4324e708e9amr10261563f8f.55.1766417194777; Mon, 22 Dec 2025 07:26:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZ+D6GZElhtNNudeGmAYKy3oDoOMLYDdQ1cS5nvDLNddsAUKI1ehqKgzPYCClwlnDLNqZr0g== X-Received: by 2002:a05:6000:402a:b0:430:f41f:bd5d with SMTP id ffacd0b85a97d-4324e708e9amr10261537f8f.55.1766417194349; Mon, 22 Dec 2025 07:26:34 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea2278dsm22897649f8f.18.2025.12.22.07.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 07:26:34 -0800 (PST) Message-ID: <0c3d6c2c2273eebcc207ce5010ed90ee80460bed.camel@redhat.com> Subject: Re: [PATCH v3 02/13] rv: Add Hybrid Automata monitor type From: Gabriele Monaco To: Nam Cao , linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org Cc: Tomas Glozar , Juri Lelli , Clark Williams , John Kacur Date: Mon, 22 Dec 2025 16:26:32 +0100 In-Reply-To: <87y0n0ib6k.fsf@yellow.woof> References: <20251205131621.135513-1-gmonaco@redhat.com> <20251205131621.135513-3-gmonaco@redhat.com> <87y0n0ib6k.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-12-18 at 12:57 +0700, Nam Cao wrote: > Gabriele Monaco writes: > > +static inline void ha_start_timer_ns(struct ha_monitor *ha_mon, enum e= nvs > > env, > > + =C2=A0=C2=A0=C2=A0=C2=A0 u64 expire, u64 time_ns) > > +{ > > + u64 passed =3D ha_invariant_passed_ns(ha_mon, env, expire, time_ns); > > + > > + ha_start_timer_jiffy(ha_mon, ENV_MAX_STORED, > > + =C2=A0=C2=A0=C2=A0=C2=A0 nsecs_to_jiffies(expire - passed) + 1, > > time_ns); >=20 > What is the +1 for? I guess to prevent it being rounded down to zero? If > so, maybe we should do >=20 > =C2=A0=C2=A0=C2=A0=C2=A0 nsecs_to_jiffies(expire - passed + TICK_NSEC - 1= ) >=20 > instead. Yeah that was the reason and your suggestion is actually cleaner. Thanks, Gabriele >=20 > Anyway, no big deal: > Reviewed-by: Nam Cao