From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FAB921579F for ; Wed, 17 Sep 2025 17:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758129442; cv=none; b=nMT1ffOcLlmV9DOtyZx5wymRaKMzmGHvCSbIQiZe0g+orZwIF7Sbwa+E9WQOLqhe59mS+lI51r/XJSNPHIR2x6B3XnNHI/XnoF90qEnkBwZhdi/A/nu9ihkOdpRVsHo5Phi4MacxpYb4NlksuPYtlr5oRCNA1T4vupidS4aNbT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758129442; c=relaxed/simple; bh=3U1LBXIuz7fukjCItzAA+L34NZHtzJ8R8A3jIrQNLp0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m1XTJbY1yBckXrmemUDCtWYx0DKpVvgIyNdOfFo7gaiG8hO1cCG+MPm/WL/YJdaOXEB0UjKdmUx1jtA/LnsjQ8DinPsGCsh5gpDHewA5csOGJrx+4ipnM+F5rOq6lGJgrktIsNpKc3obmX+vmxre3C9GNiwwkx/JpwtMnq6bLAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wt4d++SL; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wt4d++SL" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b04770a25f2so5124166b.2 for ; Wed, 17 Sep 2025 10:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758129439; x=1758734239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=T58nxE+bqTs3gFShRUYNkSGoazp+TtcIoUFVVJY4jRg=; b=Wt4d++SLCdEDNC1oC0OoDIirhRD62BdqoAhD4rJtFs7edqFjlq5PFLV2e/j2dxjMcq NEUN1pLjIjrHj1hmQSEU7qrfjS4f2Koy3Hxqf1NDL6JglhwCH/CnRZAZl9D3lp2bG5Nr mBNBVwh5ObSwm7ZBYRbSFzVS5KTPdhmVnFTjrZFFDPJjPkdQ8gqiTzTOtIdK3q+hII2D k5vdobPyIOKnW+82LEGerZcdsrBAbyP/nwyZG2/LhaiJangr72x5inlKOOf3SKpDybSI LlTmzzHKMKoUjbczB9NKqqCgu956iZY8o/5mMHw2tjxGTdkM3u6/LGtH/Hx/DjUswq1W WHSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758129439; x=1758734239; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T58nxE+bqTs3gFShRUYNkSGoazp+TtcIoUFVVJY4jRg=; b=QsYohle+eVi5fxv/yUSsveIG3decArMXmLrrfdZFvjOkrDT1HQSgMZmzqAfUj6TETY sEs8J0aSO5wHu/A82VDTIOfHPsj4mD8I3Fqosf5PFq1LlMN/ioefl97VFfw0D21vbxxG NFSvos8XLssxUmRU1HUeFQLB/yN13I6wistR3v+ZmTnFiyPTzO7TTLv4vo/x4Zo3U7MM schXq2v+Zu+vpxn5+eujAyfv4hrX2FTp3x6wPxq36x10GOaH8h8gZYHB04obU2F80hAw lHhoGHSxgjFx7V1yN0fbkuau6BHepCk9A3Bgpvav62xtS0gmq9huwqi85QUo50jeCIID mhMA== X-Forwarded-Encrypted: i=1; AJvYcCUDQOEUzgbYX8VC5HGlr/eX6kyDcOqGnTGNdL3jTigCTZRZQyvy7DVAYGYK4cf3+yQzmIhI3/qkaI2Zy1E=@vger.kernel.org X-Gm-Message-State: AOJu0YyIgxXuJFh4ZivPUV8PH/p71Y4Nzcrl31E99t4nLmWT9odAgmZV N4f7fNUssQn7dJpH6D1hl3OEAUxJLnr70M3PqT9iIo9upVPctnh1kN6n X-Gm-Gg: ASbGncvM9rNJbfzCvP37wssqn59/q/0/iHMVXNJsDmn8mT7ZxIteA9oyes2F2XcYICY wsnTD4UUCbxiZ8zPlNoYZrBaCU3wdSD7IOmoGACGGUe9SIOJQk0tnSCEqhocjIETSgy74KoUVCa KmtuOMe6TXSzwCebSfhMEbum16oR/xc57QJ4c4fQRKnlgJuSahdyVBNYZyG9uQyncHnsjjx00bT 8QybnCsFnCjdMF9qDl/bCgTCxOD97uWqK0u1OzzrTTw9958+Fz3qD//V05blFsF5ZcVeAOEJIvW LoV6RABhD1gDsWcIRPyElDXmWJaoEjb/06w+Pgz1HnTqL+pmrQM7FVSHBqFRA57zwk5bSQlveF7 BuaYScMeYYtI4w5knkIO8a/xE7xbp5e+XEwm8kxXaGkE7RlNgOXrqc+QLwvf5IUPdpLx6yHvtYp /uFsA1O5wm0ad6NLfraSbn6gwzko5M4P0xV2bzRNvMDMo/GplaqByMVf/pVqmPr7pI8s6bMfjbi +dusz11AlWTrHpRkI4= X-Google-Smtp-Source: AGHT+IF4Nz3SU9lHRKJ70fXArrCic12h6QnJ8u61QtcZkfPMX1c4mrx8Y0kwSaGD6ZJNiCo7W0YX9A== X-Received: by 2002:a17:907:3faa:b0:b04:95d2:ff6f with SMTP id a640c23a62f3a-b1bbc54779dmr312100566b.47.1758129438661; Wed, 17 Sep 2025 10:17:18 -0700 (PDT) Received: from ?IPV6:2003:ea:8f29:d000:1d6f:5a2d:6632:eea6? (p200300ea8f29d0001d6f5a2d6632eea6.dip0.t-ipconnect.de. [2003:ea:8f29:d000:1d6f:5a2d:6632:eea6]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b1fc890cc88sm11625566b.48.2025.09.17.10.17.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 10:17:18 -0700 (PDT) Message-ID: <0c5f8ebd-5ac0-4ac5-ae66-24a5acea371c@gmail.com> Date: Wed, 17 Sep 2025 19:17:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] r8169: set EEE speed down ratio to 1 To: Hau , nic_swsd , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20250904021123.5734-1-hau@realtek.com> <292e1b4d-b00d-4bb5-b55e-5684666c0229@gmail.com> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/17/2025 4:48 PM, Hau wrote: >> >> External mail : This email originated from outside the organization. Do not >> reply, click links, or open attachments unless you recognize the sender and >> know the content is safe. >> >> >> >> On 9/4/2025 4:11 AM, ChunHao Lin wrote: >>> EEE speed down ratio (mac ocp 0xe056[7:4]) is used to control EEE >>> speed down rate. The larger this value is, the more power can save. >>> But it actually save less power then expected, but will impact >>> compatibility. So set it to 1 (mac ocp 0xe056[7:4] = 0) to improve >> compatibility. >>> >>> Signed-off-by: ChunHao Lin >>> --- >> >> Reviewed-by: Heiner Kallweit > > This patch seems has been reviewed. But I did not see it been accepted. Should I resubmit the patch? Its status in patchwork is "changes requested", likely due to the fact that we had a conversation about the patch. So yes, please resubmit, with my Rb, and best also add the following, that you wrote, to the commit message. It means clock (MAC MCU) speed down. It is not from spec, so it is kind of Realtek specific feature. It may cause packet drop or interrupt loss (different hardware may have different issue).