From: Markus Elfring <Markus.Elfring@web.de>
To: "Robin Murphy" <robin.murphy@arm.com>,
iommu@lists.linux.dev, kernel-janitors@vger.kernel.org,
"Jörg Rödel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: iommu/ipmmu-vmsa: Use devm_platform_get_and_ioremap_resource() in ipmmu_probe()
Date: Mon, 5 Feb 2024 14:02:34 +0100 [thread overview]
Message-ID: <0c757d69-ec60-477c-a978-a94118a571a2@web.de> (raw)
In-Reply-To: <51315925-21ac-427c-abea-4d652ed5280f@arm.com>
>>>> Thus reuse existing functionality instead of keeping duplicate source code.
>>>
>>> Much as I detest the get_and_ioremap_resource obfuscator, it's not even appropriate here since nothing else is using "res".
>>
>> I got the impression that this local variable is needed to perform
>> a desired function call.
>
> Yes, the call to devm_ioremap_resource(). Which you're proposing to remove...
I propose to replace a specific function call combination
by an other single call for a known wrapper function.
The mentioned variable is preserved for this purpose.
Regards,
Markus
next prev parent reply other threads:[~2024-02-05 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 10:42 [PATCH] iommu/ipmmu-vmsa: Use devm_platform_get_and_ioremap_resource() in ipmmu_probe() Markus Elfring
2024-02-05 11:11 ` Robin Murphy
2024-02-05 11:52 ` Markus Elfring
2024-02-05 12:34 ` Robin Murphy
2024-02-05 13:02 ` Markus Elfring [this message]
2024-02-05 14:00 ` Robin Murphy
2024-02-05 18:29 ` Markus Elfring
2024-02-06 14:15 ` [PATCH v2] iommu/ipmmu-vmsa: Use devm_platform_ioremap_resource() " Markus Elfring
2024-02-07 9:13 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c757d69-ec60-477c-a978-a94118a571a2@web.de \
--to=markus.elfring@web.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox