From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbdKVVXG (ORCPT ); Wed, 22 Nov 2017 16:23:06 -0500 Received: from mout.web.de ([212.227.17.12]:55057 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbdKVVXE (ORCPT ); Wed, 22 Nov 2017 16:23:04 -0500 Subject: [PATCH 1/2] ASoC: cs42l52: Delete an error message for a failed memory allocation in cs42l52_i2c_probe() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Brian Austin , Jaroslav Kysela , Liam Girdwood , Mark Brown , Paul Handrigan , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <0c7a61a4-580e-e7ae-acef-047f8cff24ca@users.sourceforge.net> Date: Wed, 22 Nov 2017 22:22:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:5qHoPG5+NjfaC/ZD/HkOel3ZgT6Gb0qkcVl7YmPapsi7kkLvtuD cRsQhOpxLcBvOCoNzEQEHs8aWPtaNvl7VPQ4FQtYikh4DfPcg3Z+A6Ys6JBiKzJ4Lfu2Yjn Xd4+xdkRtVtnll7yxew/nN+2Z1gSXXUkZOONAkSJn8hRgJEjoa42MK/ntYyOfg5bsKXKu9z 9IMm2QPW+TCDjCIq1zXeA== X-UI-Out-Filterresults: notjunk:1;V01:K0:HkSUl2H4EZw=:Qq9Mxk8sQBvZRBQ+lAay1Q 1VL6Ol7qeY0f6Zk/JiO0H28yp6H+a9cSnt+cr8tA8k/cHE0KEwocZbqwDyDQOYqaazS+pEZg2 S50/3kQS61ccJvHdO4xayCK6C47+zQcyy71yGDSdxaj5DcM7jaJs+x13ar94yNg6tOJlc6YYj rI0XvyzsIOmY1pH64PbX+wdjtyRHHknnZ93FeChZeTvpM3xfXUYjnXkE9b3VnmSdhoWLGUTdy hWIa4hBKAvgQ0oGh6Fz/s7xLFasCv+UzBdbLazBVfS0E8AMfoTCmbxXTXYJdSYi6yyq11ZosM Bm+HcpojJgjnFFs2REVvrcSKeWDqwodE8jYWP0BfnQw511KLqvvc0UFZHBDt1rdYv+2p3DweW uvlLT+vpcVmMcuv2xMmp3JPV/NCFo+GjfvF3L951N1jGqrRCGwP90Ga1kNDLTcOzfsrl3XaHD RkKe8wTt0KWi5SpxR7uSfg1NOCG2Azv+UamoBMjX2JQzgZYuBGVN2Dre90IZ42BIEPX8M4EG2 vQrYrVZ8S4M08vNuHPLYkt2LSomBwghxkuKWp0bnzN+oEVSg4qayP9d9uBMoo9elzBu8YmAUr lrzc5P+HaZmObsctT0ZuH2m3dRdaVyAytpLufpg1r223UVLW/N2lxqVAkHZtIlBky6CStDRqr UV1I1hhJ7OhWOl3p4v7EeIiX1Z1V6n9z21mXSGbXmOm3uYlKomy5X0zQLatFqd464SHXGkzwq /x6pi+WxyYd98D6z4du5Q+Dq/JTK77wO/L2PXEHPvIjwytH0FNAOCWO2x/AasBT/XuwoAxg7a TXy17W3qor1iZRrORscIGpwTo8t5Yuksp8VwnbZ7mBsUdPOBaU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 22 Nov 2017 22:08:06 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/cs42l52.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c index 0d9c4a57301b..e8645f2ac0d9 100644 --- a/sound/soc/codecs/cs42l52.c +++ b/sound/soc/codecs/cs42l52.c @@ -1118,10 +1118,9 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client, pdata = devm_kzalloc(&i2c_client->dev, sizeof(struct cs42l52_platform_data), GFP_KERNEL); - if (!pdata) { - dev_err(&i2c_client->dev, "could not allocate pdata\n"); + if (!pdata) return -ENOMEM; - } + if (i2c_client->dev.of_node) { if (of_property_read_bool(i2c_client->dev.of_node, "cirrus,mica-differential-cfg")) -- 2.15.0