From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Ben Dooks <ben.dooks@sifive.com>, linux-pwm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
u.kleine-koenig@pengutronix.de,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greentime Hu <greentime.hu@sifive.com>,
William Salmon <william.salmon@sifive.com>,
Jude Onyenegecha <jude.onyenegecha@sifive.com>
Subject: Re: [PATCH v5 06/10] pwm: dwc: split pci out of core driver
Date: Mon, 10 Oct 2022 13:39:50 +0300 [thread overview]
Message-ID: <0c7e6208-307e-3788-e864-b79647c8b2a1@linux.intel.com> (raw)
In-Reply-To: <20221005221242.470734-7-ben.dooks@sifive.com>
Hi
On 10/6/22 01:12, Ben Dooks wrote:
> Moving towards adding non-pci support for the driver, move the pci
> parts out of the core into their own module. This is partly due to
> the module_driver() code only being allowed once in a module and also
> to avoid a number of #ifdef if we build a single file in a system
> without pci support.
>
> Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
> ---
> v4:
> - removed DWC_PERIOD_NS as not needed
...
> --- a/drivers/pwm/pwm-dwc.c
> +++ b/drivers/pwm/pwm-dwc.c
> -
> -#define DWC_TIMERS_TOTAL 8
> -#define DWC_CLK_PERIOD_NS 10
> -
Actually DWC_CLK_PERIOD_NS is still used here. Only the next patch 07/10
is removing usage of it so this patch is not bisect safe.
Jarkko
next prev parent reply other threads:[~2022-10-10 10:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 22:12 [PATCH v5 00/10] Designware PWM driver updates Ben Dooks
2022-10-05 22:12 ` [PATCH v5 01/10] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm-dw-apb-timers-pwm2 Ben Dooks
2022-10-06 8:13 ` Krzysztof Kozlowski
2022-10-05 22:12 ` [PATCH v5 02/10] pwm: dwc: allow driver to be built with COMPILE_TEST Ben Dooks
2022-10-05 22:12 ` [PATCH v5 03/10] pwm: dwc: change &pci->dev to dev in probe Ben Dooks
2022-10-05 22:12 ` [PATCH v5 04/10] pwm: dwc: move memory alloc to own function Ben Dooks
2022-10-05 22:12 ` [PATCH v5 05/10] pwm: dwc: use devm_pwmchip_add Ben Dooks
2022-10-05 22:12 ` [PATCH v5 06/10] pwm: dwc: split pci out of core driver Ben Dooks
2022-10-10 10:39 ` Jarkko Nikula [this message]
2022-10-20 14:47 ` Ben Dooks
2022-10-05 22:12 ` [PATCH v5 07/10] pwm: dwc: make timer clock configurable Ben Dooks
2022-10-05 22:12 ` [PATCH v5 08/10] pwm: dwc: add of/platform support Ben Dooks
2022-10-05 22:12 ` [PATCH v5 09/10] pwm: dwc: add PWM bit unset in get_state call Ben Dooks
2022-10-05 22:12 ` [PATCH v5 10/10] pwm: dwc: use clock rate in hz to avoid rounding issues Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7e6208-307e-3788-e864-b79647c8b2a1@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=ben.dooks@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=jude.onyenegecha@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=william.salmon@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox