Re: [PATCH 3/4] arm64: dts: qcom: Add dts for Medion SPRCHRGD 14 S1

[Georg Gottleuber <g.gottleuber@tuxedocomputers.com>]

Am 02.12.25 um 16:15 schrieb Konrad Dybcio:
> On 12/2/25 3:37 PM, Georg Gottleuber wrote:
>> Initial support for the Medion SPRCHRGD 14 S1, which is based on the
>> Qualcomm Snapdragon X Elite SoC (X1E78100).
> 
> [...]
> 
>> +&iris {
>> +	firmware-name = "qcom/x1e80100/medion/qcvss8380.mbn";
>> +	status = "okay";
> 
> Please add an \n above status

Ack.

>> +};
>> +
>> +&lpass_tlmm {
>> +	spkr_01_sd_n_active: spkr-01-sd-n-active-state {
>> +		pins = "gpio12";
>> +		function = "gpio";
>> +		drive-strength = <16>;
>> +		bias-disable;
>> +		output-low;
> 
> Let's drop output-low from these two, the driver controls that over
> GPIO APIs

Ack.

>> +	};
>> +
>> +	spkr_23_sd_n_active: spkr-23-sd-n-active-state {
>> +		pins = "gpio13";
>> +		function = "gpio";
>> +		drive-strength = <16>;
>> +		bias-disable;
>> +		output-low;
>> +	};
> 
> [...]
> 
>> +	eusb3_reset_n: eusb3-reset-n-state {
>> +		pins = "gpio124";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-disable;
>> +		output-low;
> 
> Similarly, for all three eUSBn, the regulator driver will assert the pin
> as necessary

Ack.

> [...]
> 
>> +		perst-n-pins {
>> +			pins = "gpio146";
>> +			function = "gpio";
>> +			drive-strength = <2>;
>> +			bias-pull-down;
> 
> PERST# is active-low, switch to bias-disable

Ack.

> [...]
> 
>> +		perst-n-pins {
>> +			pins = "gpio152";
>> +			function = "gpio";
>> +			drive-strength = <2>;
>> +			bias-disable;
> 
> just like you did here
> 
> [...]
> 
>> +	wcd_default: wcd-reset-n-active-state {
>> +		pins = "gpio191";
>> +		function = "gpio";
>> +		drive-strength = <16>;
>> +		bias-disable;
>> +		output-low;
> 
> ditto

Ack. Will drop this output-low too.

> Konrad
> 

Thanks for the review. I will implement all your hints in v2.

Regards,
Georg