From: <Bjarni.Jonasson@microchip.com>
To: <andrew@lunn.ch>
Cc: <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
<Steen.Hegelund@microchip.com>, <linux@armlinux.org.uk>,
<f.fainelli@gmail.com>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <vladimir.oltean@nxp.com>,
<davem@davemloft.net>, <hkallweit1@gmail.com>,
<atenart@kernel.org>, <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514
Date: Mon, 15 Feb 2021 09:15:41 +0000 [thread overview]
Message-ID: <0ca9c6ce3ec7d49b03367413103a3c1f152ab546.camel@microchip.com> (raw)
In-Reply-To: <YCacux8K+ocWbRQ2@lunn.ch>
On Fri, 2021-02-12 at 16:20 +0100, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote:
> > +static u32 vsc85xx_csr_read(struct phy_device *phydev,
> > + enum csr_target target, u32 reg);
> > +static int vsc85xx_csr_write(struct phy_device *phydev,
> > + enum csr_target target, u32 reg, u32
> > val);
> > +
>
> Hi Bjarni
>
> No forward definitions please. Move the code around so they are not
> required. Sometimes it is best to do such a move as a preparation
> patch.
Sure, I will remove them.
>
> > @@ -1569,8 +1664,16 @@ static int vsc8514_config_pre_init(struct
> > phy_device *phydev)
> > {0x16b2, 0x00007000},
> > {0x16b4, 0x00000814},
> > };
> > + struct device *dev = &phydev->mdio.dev;
> > unsigned int i;
> > u16 reg;
> > + int ret;
>
> Hard to say from the limited context, but is reverse christmass tree
> being preserved here?
I will dobbelcheck.
>
> Andrew
next prev parent reply other threads:[~2021-02-15 9:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 14:06 [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514 Bjarni Jonasson
2021-02-12 14:06 ` [PATCH net v1 2/3] net: phy: mscc: improved serdes calibration applied " Bjarni Jonasson
2021-02-12 16:24 ` Vladimir Oltean
2021-02-12 14:06 ` [PATCH net v1 3/3] net: phy: mscc: coma mode disabled for VSC8514 Bjarni Jonasson
2021-02-12 16:32 ` Vladimir Oltean
2021-02-15 9:36 ` Bjarni.Jonasson
2021-02-12 15:20 ` [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514 Andrew Lunn
2021-02-15 9:15 ` Bjarni.Jonasson [this message]
2021-02-12 15:54 ` Andrew Lunn
2021-02-15 9:27 ` Bjarni.Jonasson
2021-02-12 16:23 ` Vladimir Oltean
2021-02-12 18:53 ` Jakub Kicinski
2021-02-15 9:38 ` Bjarni.Jonasson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ca9c6ce3ec7d49b03367413103a3c1f152ab546.camel@microchip.com \
--to=bjarni.jonasson@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox