From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7309C43461 for ; Mon, 14 Sep 2020 09:19:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1A1F21D1A for ; Mon, 14 Sep 2020 09:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600075190; bh=QIiumx2JgDWAeVENHTZwWAcYfrAyrHP97J76nujl4Lc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VdI7h+FcqF9oMnpwxNRiOWFx2OsDIiPakg2+xCdEjxzU/ApVKZA0sfwb7J2Voo/H7 i3fkbLIQBpZ3eZCFfDMBeRAkEfnAXccBRnO6jbmgYuIra4qnbZcHerLgXT5TSnXqF2 f2KFTb7F+CmGIu5fBXrJkMWDvuxpC3YxusQincHw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbgINJTr (ORCPT ); Mon, 14 Sep 2020 05:19:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:49152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbgINJTe (ORCPT ); Mon, 14 Sep 2020 05:19:34 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3C66206B2; Mon, 14 Sep 2020 09:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600075173; bh=QIiumx2JgDWAeVENHTZwWAcYfrAyrHP97J76nujl4Lc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fRBlYh4vlRVBxg8PRKUd/4YOW0n7fYV9AuR4UAgsGazkfmNcWwk9nQDXnAa5SD4iO HzzxQYroptknH8L0QELBuvP6jCjkeTS8G3f48aUV5AeGddMFtRFZySqoruOjxW66zz bFMjdStegwim2MQCJcvSyhiCK8T7MC59RjoWvdp0= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kHke3-00BdhW-OV; Mon, 14 Sep 2020 10:19:31 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 14 Sep 2020 10:19:31 +0100 From: Marc Zyngier To: Cristian Ciocaltea Cc: Rob Herring , Manivannan Sadhasivam , Thomas Gleixner , Jason Cooper , =?UTF-8?Q?Andreas_F=C3=A4rber?= , parthiban@linumiz.com, Saravanan Sekar , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, Parthiban Nallathambi Subject: Re: [PATCH v6 2/3] irqchip: Add Actions Semi Owl SIRQ controller In-Reply-To: <20200914085154.GA8474@BV030612LT> References: <1167b847f6fe1da3834aeaadf5710ddac54f06a0.1599552438.git.cristian.ciocaltea@gmail.com> <20200914070227.GA4491@BV030612LT> <20200914085154.GA8474@BV030612LT> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <0cdd2fd4e09c7e51b8b48be914c6846f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: cristian.ciocaltea@gmail.com, robh+dt@kernel.org, manivannan.sadhasivam@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, afaerber@suse.de, parthiban@linumiz.com, sravanhome@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, pn@denx.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-14 09:51, Cristian Ciocaltea wrote: > On Mon, Sep 14, 2020 at 09:07:18AM +0100, Marc Zyngier wrote: >> Cristian, >> >> On 2020-09-14 08:02, Cristian Ciocaltea wrote: >> > Hi Marc, >> > >> > On Fri, Sep 11, 2020 at 05:22:41PM +0100, Marc Zyngier wrote: >> > > On 2020-09-08 09:20, Cristian Ciocaltea wrote: >> > > > This interrupt controller is found in the Actions Semi Owl SoCs (S500, >> > > > S700 and S900) and provides support for handling up to 3 external >> > > > interrupt lines. >> > > > >> > > > Each line can be independently configured as interrupt and triggers on >> > > > either of the edges or either of the levels. Additionally, each line >> > > > can also be masked individually. >> > > > >> > > > The patch is based on the work started by Parthiban Nallathambi: >> > > > https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@denx.de/ >> > > > >> > > > Signed-off-by: Parthiban Nallathambi >> > > > Signed-off-by: Saravanan Sekar >> > > > [cristi: optimized DT, various fixes/cleanups/improvements] >> > > > Signed-off-by: Cristian Ciocaltea >> > > >> > > Who is the author of these patches? If this is a co-development, >> > > please >> > > use the relevant tags. Otherwise, the author of the patch must come as >> > > the first SoB. >> > >> > I took the authorship for the driver patch, as mentioned in the cover >> > letter. So, if I understand correctly, my SoB should be moved on top and >> > I assume I also need to drop the related comment line. >> >> Not quite. Please look at >> Documentation/process/submitting-patches.rst. > > Yes, I have read it, but most probably I missed the information that > clarifies this authorship change handling. > >> If Parthiban and Saravanan haven't authored anything in this patch, >> then drop them from the SoB list. > > Sorry I haven't properly explained this before! > > Their contributions to the driver code stopped in 2018, when v3 of the > patch series has been submitted. > >> If they have contributed to the >> patch (which I expect), then their SoB must be preceded by their own >> Co-developed-by: tag. > > Starting with v4, the work has been done exclusively by myself. > >> To sum it up, it probably should look like: >> >> Co-developed-by: Parthiban Nallathambi >> Signed-off-by: Parthiban Nallathambi >> Co-developed-by: Saravanan Sekar >> Signed-off-by: Saravanan Sekar >> Signed-off-by: Cristian Ciocaltea >> >> This is of course an assumption, and you should check it with the >> individuals above. > > I have recently contacted Parthiban and he agreed that I can take the > authorship. So I should proceed with the 1st approach? The authorship of the patch is one thing, acknowledging the work done by others is another. As you said above, you started by contributing to an existing series, instead of writing it from scratch. You changed it to a degree where it makes sense for you to be the author of the patches, but it doesn't invalidate the contributions made by others before you. Unless the two other contributors explicitly say they'd rather not be named, I don't see how you can avoid mentioning them. Thanks, M. -- Jazz is not dead. It just smells funny...