Re: [PATCH v5 02/11] ACPI: CPPC: Clean up cppc_perf_caps and cppc_perf_ctrls structs

Pierre Gondois
2026-01-08T13:44:29Z

On 12/23/25 13:12, Sumit Gupta wrote:
> - Remove redundant energy_perf field from 'struct cppc_perf_caps' as
> the same is available in 'struct cppc_perf_ctrls' which is used.
> - Move the 'auto_sel' field from 'struct cppc_perf_caps' to
> 'struct cppc_perf_ctrls' as it represents a control register.

I think your SoB is missing, otherwise:

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

> ---
> include/acpi/cppc_acpi.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
> index 13fa81504844..a090b010f5f1 100644
> --- a/include/acpi/cppc_acpi.h
> +++ b/include/acpi/cppc_acpi.h
> @@ -119,8 +119,6 @@ struct cppc_perf_caps {
> u32 lowest_nonlinear_perf;
> u32 lowest_freq;
> u32 nominal_freq;
> - u32 energy_perf;
> - bool auto_sel;
> };
>
> struct cppc_perf_ctrls {
> @@ -128,6 +126,7 @@ struct cppc_perf_ctrls {
> u32 min_perf;
> u32 desired_perf;
> u32 energy_perf;
> + bool auto_sel;
> };
>
> struct cppc_perf_fb_ctrs {