From: Wojciech Drewek <wojciech.drewek@intel.com>
To: Ratheesh Kannoth <rkannoth@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [EXT] Re: [PATCH net] octeontx2-pf: Fix holes in error code
Date: Thu, 26 Oct 2023 12:56:26 +0200 [thread overview]
Message-ID: <0d1cb5d7-53e8-45bd-ad45-48fae64b8d9c@intel.com> (raw)
In-Reply-To: <MWHPR1801MB1918043F69F45C9D69656449D3DDA@MWHPR1801MB1918.namprd18.prod.outlook.com>
On 26.10.2023 12:37, Ratheesh Kannoth wrote:
>> From: Wojciech Drewek <wojciech.drewek@intel.com>
>> Sent: Thursday, October 26, 2023 3:44 PM
>> Subject: [EXT] Re: [PATCH net] octeontx2-pf: Fix holes in error code
>>
>>> static char *nix_snd_status_e_str[NIX_SND_STATUS_MAX] = {
>>> - "NIX_SND_STATUS_GOOD",
>>> - "NIX_SND_STATUS_SQ_CTX_FAULT",
>>> - "NIX_SND_STATUS_SQ_CTX_POISON",
>>> - "NIX_SND_STATUS_SQB_FAULT",
>>> - "NIX_SND_STATUS_SQB_POISON",
>>> - "NIX_SND_STATUS_HDR_ERR",
>>> - "NIX_SND_STATUS_EXT_ERR",
>>> - "NIX_SND_STATUS_JUMP_FAULT",
>>> - "NIX_SND_STATUS_JUMP_POISON",
>>> - "NIX_SND_STATUS_CRC_ERR",
>>> - "NIX_SND_STATUS_IMM_ERR",
>>> - "NIX_SND_STATUS_SG_ERR",
>>> - "NIX_SND_STATUS_MEM_ERR",
>>> - "NIX_SND_STATUS_INVALID_SUBDC",
>>> - "NIX_SND_STATUS_SUBDC_ORDER_ERR",
>>> - "NIX_SND_STATUS_DATA_FAULT",
>>> - "NIX_SND_STATUS_DATA_POISON",
>>> - "NIX_SND_STATUS_NPC_DROP_ACTION",
>>> - "NIX_SND_STATUS_LOCK_VIOL",
>>> - "NIX_SND_STATUS_NPC_UCAST_CHAN_ERR",
>>> - "NIX_SND_STATUS_NPC_MCAST_CHAN_ERR",
>>> - "NIX_SND_STATUS_NPC_MCAST_ABORT",
>>> - "NIX_SND_STATUS_NPC_VTAG_PTR_ERR",
>>> - "NIX_SND_STATUS_NPC_VTAG_SIZE_ERR",
>>> - "NIX_SND_STATUS_SEND_STATS_ERR",
>>> + [NIX_SND_STATUS_GOOD] = "NIX_SND_STATUS_GOOD",
>>> + [NIX_SND_STATUS_SQ_CTX_FAULT] =
>> "NIX_SND_STATUS_SQ_CTX_FAULT",
>>> + [NIX_SND_STATUS_SQ_CTX_POISON] =
>> "NIX_SND_STATUS_SQ_CTX_POISON",
>>> + [NIX_SND_STATUS_SQB_FAULT] = "NIX_SND_STATUS_SQB_FAULT",
>>> + [NIX_SND_STATUS_SQB_POISON] =
>> "NIX_SND_STATUS_SQB_POISON",
>>> + [NIX_SND_STATUS_HDR_ERR] = "NIX_SND_STATUS_HDR_ERR",
>>> + [NIX_SND_STATUS_EXT_ERR] = "NIX_SND_STATUS_EXT_ERR",
>>> + [NIX_SND_STATUS_JUMP_FAULT] =
>> "NIX_SND_STATUS_JUMP_FAULT",
>>> + [NIX_SND_STATUS_JUMP_POISON] =
>> "NIX_SND_STATUS_JUMP_POISON",
>>> + [NIX_SND_STATUS_CRC_ERR] = "NIX_SND_STATUS_CRC_ERR",
>>> + [NIX_SND_STATUS_IMM_ERR] = "NIX_SND_STATUS_IMM_ERR",
>>> + [NIX_SND_STATUS_SG_ERR] = "NIX_SND_STATUS_SG_ERR",
>>> + [NIX_SND_STATUS_MEM_ERR] = "NIX_SND_STATUS_MEM_ERR",
>>> + [NIX_SND_STATUS_INVALID_SUBDC] =
>> "NIX_SND_STATUS_INVALID_SUBDC",
>>> + [NIX_SND_STATUS_SUBDC_ORDER_ERR] =
>> "NIX_SND_STATUS_SUBDC_ORDER_ERR",
>>> + [NIX_SND_STATUS_DATA_FAULT] =
>> "NIX_SND_STATUS_DATA_FAULT",
>>> + [NIX_SND_STATUS_DATA_POISON] =
>> "NIX_SND_STATUS_DATA_POISON",
>>> + [NIX_SND_STATUS_NPC_DROP_ACTION] =
>> "NIX_SND_STATUS_NPC_DROP_ACTION",
>>> + [NIX_SND_STATUS_LOCK_VIOL] = "NIX_SND_STATUS_LOCK_VIOL",
>>> + [NIX_SND_STATUS_NPC_UCAST_CHAN_ERR] =
>> "NIX_SND_STATUS_NPC_UCAST_CHAN_ERR",
>>> + [NIX_SND_STATUS_NPC_MCAST_CHAN_ERR] =
>> "NIX_SND_STATUS_NPC_MCAST_CHAN_ERR",
>>> + [NIX_SND_STATUS_NPC_MCAST_ABORT] =
>> "NIX_SND_STATUS_NPC_MCAST_ABORT",
>>> + [NIX_SND_STATUS_NPC_VTAG_PTR_ERR] =
>> "NIX_SND_STATUS_NPC_VTAG_PTR_ERR",
>>> + [NIX_SND_STATUS_NPC_VTAG_SIZE_ERR] =
>> "NIX_SND_STATUS_NPC_VTAG_SIZE_ERR",
>>> + [NIX_SND_STATUS_SEND_MEM_FAULT] =
>> "NIX_SND_STATUS_SEND_MEM_FAULT",
>>> + [NIX_SND_STATUS_SEND_STATS_ERR] =
>> "NIX_SND_STATUS_SEND_STATS_ERR",
>>> };
>>>
>>> @@ -318,23 +318,23 @@ enum nix_snd_status_e {
>>> NIX_SND_STATUS_EXT_ERR = 0x6,
>>> NIX_SND_STATUS_JUMP_FAULT = 0x7,
>>> NIX_SND_STATUS_JUMP_POISON = 0x8,
>>> - NIX_SND_STATUS_CRC_ERR = 0x9,
>>> - NIX_SND_STATUS_IMM_ERR = 0x10,
>>> - NIX_SND_STATUS_SG_ERR = 0x11,
>>> - NIX_SND_STATUS_MEM_ERR = 0x12,
>>> - NIX_SND_STATUS_INVALID_SUBDC = 0x13,
>>> - NIX_SND_STATUS_SUBDC_ORDER_ERR = 0x14,
>>> - NIX_SND_STATUS_DATA_FAULT = 0x15,
>>> - NIX_SND_STATUS_DATA_POISON = 0x16,
>>> - NIX_SND_STATUS_NPC_DROP_ACTION = 0x17,
>>> - NIX_SND_STATUS_LOCK_VIOL = 0x18,
>>> - NIX_SND_STATUS_NPC_UCAST_CHAN_ERR = 0x19,
>>> - NIX_SND_STATUS_NPC_MCAST_CHAN_ERR = 0x20,
>>> - NIX_SND_STATUS_NPC_MCAST_ABORT = 0x21,
>>> - NIX_SND_STATUS_NPC_VTAG_PTR_ERR = 0x22,
>>> - NIX_SND_STATUS_NPC_VTAG_SIZE_ERR = 0x23,
>>> - NIX_SND_STATUS_SEND_MEM_FAULT = 0x24,
>>> - NIX_SND_STATUS_SEND_STATS_ERR = 0x25,
>>> + NIX_SND_STATUS_CRC_ERR = 0x10,> +
>> NIX_SND_STATUS_IMM_ERR = 0x11,
>>> + NIX_SND_STATUS_SG_ERR = 0x12,
>>> + NIX_SND_STATUS_MEM_ERR = 0x13,
>>> + NIX_SND_STATUS_INVALID_SUBDC = 0x14,
>>> + NIX_SND_STATUS_SUBDC_ORDER_ERR = 0x15,
>>> + NIX_SND_STATUS_DATA_FAULT = 0x16,
>>> + NIX_SND_STATUS_DATA_POISON = 0x17,
>>
>> There is a gap here, is it intended?
> [Ratheesh Kannoth] Yes.
>
>> And in general, why error codes were changed?
> [Ratheesh Kannoth] it was a bug.
>
>> Starting from NIX_SND_STATUS_CRC_ERR which was 0x09 and now it's 0x10.
> [Ratheesh Kannoth] Yes. It should be 0x10 . The real issue is - >enum was not in sequence. (Eg ,,after 0x9 it should be 0xa). But
> "static char *nix_snd_status_e_str" was assigned sequential strings.
Ok, got it now.
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
I'd add to the commit msg that some error values were wrong and it it was fixed, but it's a nit.
>
>>
>>> + NIX_SND_STATUS_NPC_DROP_ACTION = 0x20,
>>> + NIX_SND_STATUS_LOCK_VIOL = 0x21,
>>> + NIX_SND_STATUS_NPC_UCAST_CHAN_ERR = 0x22,
>>> + NIX_SND_STATUS_NPC_MCAST_CHAN_ERR = 0x23,
>>> + NIX_SND_STATUS_NPC_MCAST_ABORT = 0x24,
>>> + NIX_SND_STATUS_NPC_VTAG_PTR_ERR = 0x25,
>>> + NIX_SND_STATUS_NPC_VTAG_SIZE_ERR = 0x26,
>>> + NIX_SND_STATUS_SEND_MEM_FAULT = 0x27,
>>> + NIX_SND_STATUS_SEND_STATS_ERR = 0x28,
>>> NIX_SND_STATUS_MAX,
>>> };
>>>
next prev parent reply other threads:[~2023-10-26 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 3:01 [PATCH net] octeontx2-pf: Fix holes in error code Ratheesh Kannoth
2023-10-26 10:14 ` Wojciech Drewek
2023-10-26 10:37 ` [EXT] " Ratheesh Kannoth
2023-10-26 10:56 ` Wojciech Drewek [this message]
2023-10-26 21:52 ` Jakub Kicinski
2023-10-27 2:01 ` Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d1cb5d7-53e8-45bd-ad45-48fae64b8d9c@intel.com \
--to=wojciech.drewek@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox