From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbeDSPQe (ORCPT ); Thu, 19 Apr 2018 11:16:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55006 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbeDSPQb (ORCPT ); Thu, 19 Apr 2018 11:16:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2589760500 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 09/61] dmaengine: qcom: simplify getting .drvdata To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Gross , David Brown , Vinod Koul , Dan Williams , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, dmaengine@vger.kernel.org References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-10-wsa+renesas@sang-engineering.com> From: Sinan Kaya Message-ID: <0d22fa16-1511-33ed-363e-fc42e4287aa0@codeaurora.org> Date: Thu, 19 Apr 2018 11:16:26 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180419140641.27926-10-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/19/2018 10:05 AM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy. Please apply individually. > > drivers/dma/qcom/hidma.c | 3 +-- > drivers/dma/qcom/hidma_mgmt_sys.c | 6 ++---- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c > index 963cc5228d05..43d4b00b8138 100644 > --- a/drivers/dma/qcom/hidma.c > +++ b/drivers/dma/qcom/hidma.c > @@ -616,8 +616,7 @@ static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg) > static ssize_t hidma_show_values(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct hidma_dev *mdev = platform_get_drvdata(pdev); > + struct hidma_dev *mdev = dev_get_drvdata(dev); > > buf[0] = 0; > > diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgmt_sys.c > index d61f1068a34b..cbb89eafd844 100644 > --- a/drivers/dma/qcom/hidma_mgmt_sys.c > +++ b/drivers/dma/qcom/hidma_mgmt_sys.c > @@ -107,8 +107,7 @@ static struct hidma_mgmt_fileinfo hidma_mgmt_files[] = { > static ssize_t show_values(struct device *dev, struct device_attribute *attr, > char *buf) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct hidma_mgmt_dev *mdev = platform_get_drvdata(pdev); > + struct hidma_mgmt_dev *mdev = dev_get_drvdata(dev); > unsigned int i; > > buf[0] = 0; > @@ -125,8 +124,7 @@ static ssize_t show_values(struct device *dev, struct device_attribute *attr, > static ssize_t set_values(struct device *dev, struct device_attribute *attr, > const char *buf, size_t count) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct hidma_mgmt_dev *mdev = platform_get_drvdata(pdev); > + struct hidma_mgmt_dev *mdev = dev_get_drvdata(dev); > unsigned long tmp; > unsigned int i; > int rc; > Reviewed-by: Sinan Kaya -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.