From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbcGTPIj (ORCPT ); Wed, 20 Jul 2016 11:08:39 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37849 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752748AbcGTPIb (ORCPT ); Wed, 20 Jul 2016 11:08:31 -0400 Subject: Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting To: Wolfram Sang References: <20160716022831.GA7636@d830.WORKGROUP> <578C9843.10408@nvidia.com> <20160719071343.GA2086@tetsubishi> Cc: Laxman Dewangan , Alison Schofield , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Linux I2C From: Jonathan Cameron Message-ID: <0d515ff9-252a-a8f9-49c1-89ef0b1e9887@kernel.org> Date: Wed, 20 Jul 2016 16:08:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160719071343.GA2086@tetsubishi> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/07/16 08:13, Wolfram Sang wrote: > On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote: >> On 18/07/16 09:50, Laxman Dewangan wrote: >>> >>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote: >>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting >>>> auto-detection. IIO drivers don't typically use .class. >>>> Remove it. >>>> >>>> Signed-off-by: Alison Schofield >>>> Cc: Daniel Baluta >>>> >>> >>> Agree. >>> Acked-by: Laxman Dewangan >> Any resulting ABI change from dropping it? > > What do you mean with ABI? This is only relevant for "automatic" > instantiation. Cool, I was just being paranoid and didn't have time to check! Thanks, Jonathan > From me: > > Acked-by: Wolfram Sang >