Re: [PATCH v2] remoteproc: mediatek: fix side effect of mt8195 sram power on

kernel test robot
2022-03-11T16:58:54Z

Hi Tinghan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on remoteproc/rproc-next]
[also build test ERROR on v5.17-rc7 next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Tinghan-Shen/remoteproc-mediatek-fix-side-effect-of-mt8195-sram-power-on/20220311-203255
base: git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git rproc-next
config: parisc-randconfig-r031-20220310 (https://download.01.org/0day-ci/archive/20220312/202203120056.qtDEVoye-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6d56ab3bae4e0d5e07d295169602883ba7d7de08
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tinghan-Shen/remoteproc-mediatek-fix-side-effect-of-mt8195-sram-power-on/20220311-203255
git checkout 6d56ab3bae4e0d5e07d295169602883ba7d7de08
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash drivers/remoteproc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/remoteproc/mtk_scp.c: In function 'mt8195_scp_before_load':
>> drivers/remoteproc/mtk_scp.c:418:27: error: 'MT8195_L1TCM_SRAM_PDN_RESERVED_BITS' undeclared (first use in this function); did you mean 'MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS'?
418 | MT8195_L1TCM_SRAM_PDN_RESERVED_BITS);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS
drivers/remoteproc/mtk_scp.c:418:27: note: each undeclared identifier is reported only once for each function it appears in
drivers/remoteproc/mtk_scp.c: In function 'mt8195_scp_stop':
drivers/remoteproc/mtk_scp.c:592:28: error: 'MT8195_L1TCM_SRAM_PDN_RESERVED_BITS' undeclared (first use in this function); did you mean 'MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS'?
592 | MT8195_L1TCM_SRAM_PDN_RESERVED_BITS);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS

vim +418 drivers/remoteproc/mtk_scp.c

405
406 static int mt8195_scp_before_load(struct mtk_scp *scp)
407 {
408 /* clear SPM interrupt, SCP2SPM_IPC_CLR */
409 writel(0xff, scp->reg_base + MT8192_SCP2SPM_IPC_CLR);
410
411 writel(1, scp->reg_base + MT8192_CORE0_SW_RSTN_SET);
412
413 /* enable SRAM clock */
414 scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0);
415 scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0);
416 scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0);
417 scp_sram_power_on(scp->reg_base + MT8192_L1TCM_SRAM_PDN,
> 418 MT8195_L1TCM_SRAM_PDN_RESERVED_BITS);
419 scp_sram_power_on(scp->reg_base + MT8192_CPU0_SRAM_PD, 0);
420
421 /* enable MPU for all memory regions */
422 writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF);
423
424 return 0;
425 }
426

---
0-DAY CI Kernel Test Service