Re: [PATCH v2] remoteproc: mediatek: fix side effect of mt8195 sram power on

Tinghan Shen
2022-03-14T11:12:22Z

Hi Miles,

On Sun, 2022-03-13 at 08:01 +0800, Miles Chen wrote:
> Hi Tinghan,
>
> > 418 | MT8195_L1TCM_SRAM_PDN_RESERVED_BITS);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS
> > drivers/remoteproc/mtk_scp.c:418:27: note: each undeclared identifier is reported only once
> > for each function it appears in
> > drivers/remoteproc/mtk_scp.c: In function 'mt8195_scp_stop':
> > drivers/remoteproc/mtk_scp.c:592:28: error: 'MT8195_L1TCM_SRAM_PDN_RESERVED_BITS' undeclared
> > (first use in this function); did you mean 'MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS'?
> > 592 | MT8195_L1TCM_SRAM_PDN_RESERVED_BITS);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS
>
> I tested this patch and it can should be caught by the
> internal build test.
>
> Could you do the test before submitting patches out?
>
>
> Thanks,
> Miles

I'm Sorry. I was too confident for this change.
I'll do the test at next time.
Thank you.

Best regards,
TingHan