From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932855AbcIUH2T (ORCPT ); Wed, 21 Sep 2016 03:28:19 -0400 Received: from mout.web.de ([212.227.15.3]:50250 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752852AbcIUH2R (ORCPT ); Wed, 21 Sep 2016 03:28:17 -0400 Subject: [PATCH 4/5] GPU-DRM-nouveau: Adjust a kzalloc() call in gt215_ram_new() To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Ben Skeggs , David Airlie , Martin Peres , Roy Spliet References: <5bcff2ec-f3bd-ab9c-e13d-3a4f5cf7c73b@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, trivial@kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <0d8628f4-7254-2600-9ee4-e72b4e0ee6f6@users.sourceforge.net> Date: Wed, 21 Sep 2016 09:28:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <5bcff2ec-f3bd-ab9c-e13d-3a4f5cf7c73b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7rjrv9e1d/OJi3LZ+Wzs1it5I4eEAbQsRskrPh1qI3YB83DcVCE M3qozgSGIi6q7CeZf7FiMQI3b/32qmVsKXcrwB0aPsdencpEIDB1Ju1pDdfjx0ci/1Kd6kc 5ZwxfyICSK7gX3tHfRCq8k1Y5sTKLcSoeztIrAzBr1nlsGsO7VQEtSte+Rb1193bFva/7gX 6kjMI9D/QlO0fxXZX6+0Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:ffgeooE+OuM=:b7XkVW+tLLrcx8UqNG6CWc SPMC+7izwKc3Q73f1GdWGzw98tclOQjrkbTSq4Va7I1+fAqrEoYFUWGVRvx6IRaE3x3mt/12H ZUd/9jEFZZ4A6OuTqHR7VzPKaoWFB3b8ywwaf7V8eDgUZiIp2Ab9kWXAnEWLlRzvOqJSk1H/u WBeVuT8MZMuVQr5Zq8BnjR8d4AIH/C6qtrmKDL6QGteNk/5A6114iqeDr/lpY/ntKoHWVvw7D N9EWHT6qrPeYiqXTd2IuTsaXzIlSS6hHRUhxM7z9oNDbp56E49l0tfmiyKNxUmwgQz/Ix7ciQ DZ20TCocjqCIw+eNwnUEf51IG7bA9QdbbUtRMjrz5U9uMrWnX7XVMdJvUsnS9707YT4F1AuI3 DMgrgXMmxdg8N5OmO0d7Mv64wedOOME6WrPk7T86FolxcWhdghE5IYNG1hCAPVpoYqxTFNEW5 I/jdSL3zzOzstUt91O0dvkwwm4X8GsDFWQFBzeS9PFKnItHWYE3U2iTrcNxIcThJR4AtJqjZC vca2mjdofYQT3zXd8Rqa3C7FAzgR8H+J6GOA4j+47aPP1eqd1TdSiAbd6AyUtEBo03q08XJ62 CR5gqoIysK0ZjJ2Ssr4s2sqHgYvFI9IB/noebs1oAXHnnXONstJsa6PmvkRixPao3enzfpAfp Spm/1Jtp11uyjbW26Pkx4C364cXXj5TRgHbRBQ6GVNjAM/hV1QIjanjpL4zeyikZuaX/h3gdD dhSvp3Z8a9Al9aBFuPhiPUhREJMLvY1QTI9wJG2s012q7VS9QwqWp9h88quH2prP0NOAGyXRO XXKrE7q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 21 Sep 2016 08:44:38 +0200 The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move the assignment for one local variable to a separate statement in this function. Signed-off-by: Markus Elfring --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c index cb50539..edbe8e4 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c @@ -940,7 +940,8 @@ gt215_ram_new(struct nvkm_fb *fb, struct nvkm_ram **pram) struct gt215_ram *ram; int ret, i; - if (!(ram = kzalloc(sizeof(*ram), GFP_KERNEL))) + ram = kzalloc(sizeof(*ram), GFP_KERNEL); + if (!ram) return -ENOMEM; *pram = &ram->base; -- 2.10.0