From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B04C433EF for ; Thu, 7 Apr 2022 03:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240658AbiDGDim (ORCPT ); Wed, 6 Apr 2022 23:38:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240650AbiDGDi1 (ORCPT ); Wed, 6 Apr 2022 23:38:27 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A96ED241B69 for ; Wed, 6 Apr 2022 20:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649302588; x=1680838588; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=fNARzUYWCWEFMOy3OrUny7NCKu8gMH3rlx8PZw5PQfw=; b=k2IVZEd2vhg8Xv8MmNuAksOEEBYynZm8ar2m/YzHiJ8pT8MufuwtryOC 8X3nfFgpHS7hVZU+1u0GzMJ7odEQPXNvdp8x1egCgudE2ZSNjXD439XZW oeL+1tDcqUGFby1VXzdHrbGPMVi2tWueexsbCt4gbxNtbfYnArOx73yq0 FbcSMjHrmphpynhH1dn9HSye6241cHy9vZiyS8wWClC8o9KnX9kxZ5cZm UGnHxjlif71f0ahbfuXPiGGrfey7c1ZnQnWcHVlM8Ivz3DjM4F1nO59jV dcslLNxEdpXFWphS7CaGz1AIfotqluzWjXl6N8KKop5g/7akiPvk8QdTA A==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="241811321" X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="241811321" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 20:36:28 -0700 X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="505987677" Received: from arkadee1-mobl.amr.corp.intel.com (HELO [10.209.98.109]) ([10.209.98.109]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 20:36:27 -0700 Message-ID: <0dac70ef-1355-3379-ef41-eec6467886b1@linux.intel.com> Date: Wed, 6 Apr 2022 22:08:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH v4 3/4] ASoC: Intel: sof_es8336: add a quirk for headset at mic1 port Content-Language: en-US To: Mauro Carvalho Chehab , alsa-devel@alsa-project.org Cc: Hans de Goede , =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= , Bard Liao , Cezary Rojewski , Jaroslav Kysela , Jie Yang , Liam Girdwood , Mark Brown , Takashi Iwai , linux-kernel@vger.kernel.org References: From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int sof_es8316_speaker_power_event(struct snd_soc_dapm_widget *w, > @@ -145,13 +148,23 @@ static const struct snd_soc_dapm_route sof_es8316_audio_map[] = { > {"Speaker", NULL, "HPOL"}, > {"Speaker", NULL, "HPOR"}, > {"Speaker", NULL, "Speaker Power"}, > + > + {"Differential Mux", "lin1-rin1", "MIC1"}, > + {"Differential Mux", "lin2-rin2", "MIC2"}, > + {"Differential Mux", "lin1-rin1 with 20db Boost", "MIC1"}, > + {"Differential Mux", "lin2-rin2 with 20db Boost", "MIC2"}, this is surprising, shouldn't this be part of the codec driver? The part that should be machine-specific is really how MIC1 or MIC2 are connected (as done below), but the routes above seem machine-independent? Or is this a work-around for a miss in the codec driver? Confused... > }; > > -static const struct snd_soc_dapm_route sof_es8316_intmic_in1_map[] = { > +static const struct snd_soc_dapm_route sof_es8316_headset_mic2_map[] = { > {"MIC1", NULL, "Internal Mic"}, > {"MIC2", NULL, "Headset Mic"}, > }; > > +static const struct snd_soc_dapm_route sof_es8316_headset_mic1_map[] = { > + {"MIC2", NULL, "Internal Mic"}, > + {"MIC1", NULL, "Headset Mic"}, > +}; > +