From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chunhai Guo <guochunhai@vivo.com>,
"linux-erofs@lists.ozlabs.org" <linux-erofs@lists.ozlabs.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] erofs: get rid of erofs_{find,insert}_workgroup
Date: Fri, 18 Oct 2024 12:43:12 +0800 [thread overview]
Message-ID: <0db205f7-85f7-41ec-93f7-2077ee3dfb9a@linux.alibaba.com> (raw)
In-Reply-To: <cd756ca4-e83b-4b10-8792-fc0f1c1ae2fa@vivo.com>
On 2024/10/18 12:30, Chunhai Guo wrote:
>> @@ -789,7 +798,16 @@ static int z_erofs_pcluster_begin(struct z_erofs_decompress_frontend *fe)
>> DBG_BUGON(fe->owned_head == Z_EROFS_PCLUSTER_NIL);
>>
>> if (!(map->m_flags & EROFS_MAP_META)) {
>> - grp = erofs_find_workgroup(sb, blknr);
>> + while (1) {
>> + rcu_read_lock();
>> + grp = xa_load(&EROFS_SB(sb)->managed_pslots, blknr);
>> + if (erofs_workgroup_get(grp)) {
> I guess here should be modified as below, please refer to
> erofs_find_workgroup().
Yeah, nice catch! Will fix it in the next version.
Thanks,
Gao Xiang
prev parent reply other threads:[~2024-10-18 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 11:57 [PATCH 1/3] erofs: get rid of erofs_{find,insert}_workgroup Gao Xiang
2024-10-17 11:57 ` [PATCH 2/3] erofs: move erofs_workgroup operations into zdata.c Gao Xiang
2024-10-17 11:57 ` [PATCH 3/3] erofs: sunset `struct erofs_workgroup` Gao Xiang
2024-10-18 4:30 ` [PATCH 1/3] erofs: get rid of erofs_{find,insert}_workgroup Chunhai Guo
2024-10-18 4:43 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0db205f7-85f7-41ec-93f7-2077ee3dfb9a@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=guochunhai@vivo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox