From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>
Subject: Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2
Date: Fri, 6 Jan 2017 14:47:38 -0800 [thread overview]
Message-ID: <0dbf9730-2409-30f9-e9e4-946fe7fec413@gmail.com> (raw)
In-Reply-To: <20170106222008.GC10626@lunn.ch>
On 01/06/2017 02:20 PM, Andrew Lunn wrote:
>> If one wants to rename an interface, udev rules can be used as usual.
>
> Hi Vivien
>
> Do you have some examples?
>
> A quick look at udevadm info suggests we can use
>
> ATTR{phys_port_id} and ATTR{phys_switch_id}
>
> Humm, it would be nice to know why the second switch has a
> phys_switch_id of 01000000.
Well, that's a combination of being on a little endian system and using
%*phN as a printk formatter, and the type being 32-bit long (int). I
agree this does not feel natural, but since this is sysfs (so ABI in a
way), it's going to be though to change now.
--
Florian
next prev parent reply other threads:[~2017-01-06 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 22:00 [PATCH net-next 0/2] net: dsa: make "label" property optional Vivien Didelot
2017-01-06 22:00 ` [PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2 Vivien Didelot
2017-01-06 22:20 ` Andrew Lunn
2017-01-06 22:47 ` Florian Fainelli [this message]
2017-01-07 20:28 ` Uwe Kleine-König
2017-01-07 20:31 ` Uwe Kleine-König
2017-01-06 22:00 ` [PATCH net-next 2/2] arm: dts: vf610-zii-dev-rev-b: remove ports label Vivien Didelot
2017-01-06 22:41 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dbf9730-2409-30f9-e9e4-946fe7fec413@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=uwe@kleine-koenig.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox