From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CC8D44D034 for ; Tue, 28 Apr 2026 13:36:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777383420; cv=none; b=QiK89CKN53H/11qVD1/XSiAHa7wY7c9oa0i6E1bqnjvLP6Z/ToAWx+W2m5Fd5XA1DKr8Xeu98SevLcunyAhU8Otf9i6P5NpIpUeWYG7otM0bPIMxOy6qv398rutTAGZ5G1t5eZ6dK8d1znVmO+zbHKYvvh+e663hixP6WDKMbhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777383420; c=relaxed/simple; bh=omKdTqW56cQNgMCJYhjGQoBYjcJDylgCWQlF/x9N2vw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QqvoVsRI5r80lhu3ZDWkRqDJCwllrL6B7SMbGdHqxMzXxwfyTHZ3JGi5mkwRFiw106Gx1mVWj9/8IbQx5opoZgl7vNPscfpcgvTBwBZP0a3rZ0n/7EH9a6cc0HfZFPgnQkfVRvgsuZUR86b4soJXbDAhjJXsV27HwImD8xaSVw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=csFU2Z6q; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="csFU2Z6q" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso119479745e9.1 for ; Tue, 28 Apr 2026 06:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777383418; x=1777988218; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GaLbgtCyLwXTc2vjiwqYx7+YT/HZgQXbQZLJbUSF57E=; b=csFU2Z6qErP0/paUJ7Hl7tDR6JuhOJqW0pA8OCcLHOH2OT6ItnznkCZ66P4fCPmf/M kPyNXSO6yTEohjTVgFJFylAySVTZTMoctH/KhPqjND3K7yC9aY2ZSDMuewiXpHeGiskr CvWwWB8n1ttbE8Oc3L+mj7ylfyX6G4fqIDmDk803XuK40SlFDkq4HvGV4V2P6Ht1ZGF/ HliMf6BWdwCeToH9wBoFau5dfLbgJwhWSb9WR+HGg0/hM3ASWHbkug1lTmf33ZCLlB5D 8NXQwpedPORrv1rUl0UrI+g7Xom7Z9RXQRshuc4/8AbMwiG/Oh5Lvdpd6hzbmJtzFm5e YdnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777383418; x=1777988218; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GaLbgtCyLwXTc2vjiwqYx7+YT/HZgQXbQZLJbUSF57E=; b=lWT7sKRO5JEiECXlzPMicYOukLvD2R73qS+YwOLdC+BdNiqyL+Th4trxorDUy9ieUY lfypF3i1fkdqFDW+mH213Af3+FP9GYjK+t+rh1Lw1+hzhaNLGRqKimlGxOM7rOdLYh2e gIOefTlS67SbQbPbHnLwZFfs6Xt1C6sgtiSd7O0CkVRbqFbYkcMfPxCEVWk0B1hPcvi1 H0TspzisJun3h3RnxDkp7J1WDATiJZyxsljW9Z+6hddcRbSPfZb14jjNzAfcY4PkYLbR T2kUsbxjkwbVX9pRtyqxBc22mk9vgA5sJ9KfJwIfhbIg5hysmQbrarNIHgdt8QUuS1Q0 13NA== X-Forwarded-Encrypted: i=1; AFNElJ9ewNY5X45s6nARniGm2QmbveFA0ysQAFY4NbLuorv2F35JmvPQoglCrYnqiaPRJ0SBSAVuOdLZ4xLykO4=@vger.kernel.org X-Gm-Message-State: AOJu0YxLYfDeu8khd0ezu6txhKR3Y9ZlOl+sFQt/OpwdduNq8xkK2FJd ZHq0EIRruDmLjd/eAlCa9k2cdo5NwJ1VGBOSfVija6GF40pNKf6Qg0gV X-Gm-Gg: AeBDievcX0JzB14+gBywWrER23QKaXFCXJW7KJbIlMOUFWWfbDp7tvcoWaEWHSS3ARH woqNEA5dYUMSaWWkg7f4jd5vG0u5PQKjEhPWQQlc0onl/oPqyEEjnrWa4Vdh7qamen1XEm7Ssva C+1M8GcVUDl8pTZJxsmDGvekzjDgz1V7VfQBxzr5TIs6B8VdPUp4kFAnfGZeJPITBv97BUcZkfu rR4ZJqA2nq3hVsnzRk33uSjgTBZmg7bGr4dh7WFu1/XtGMqdaeoW+MFHRTkYlzUznkBU8xrRF44 L/VgcVxVOFMSh0hir/1rUISzH/SF7OJmcCMru2xCZXeZKAGIR9yqzd9qTOD1B6CLSgQFci85Udj iXyJisXmYve53Bpb1McmpkKQsfLdlGg+/uP5ZknjI2h/NAkJGDhYx7lrGsoVjszWWZvHfzdjYkf l4j14DbCSLIvfBymBXrc2NO048MvlJL5QimQYPPi5J98RQm8EOrfJcUNy55EJNfTbF6haTGRp6F 8AUfvrf/SEmm30oc92UNsZ2 X-Received: by 2002:a05:600c:8b4c:b0:48a:65ad:1881 with SMTP id 5b1f17b1804b1-48a77af28f1mr52177695e9.13.1777383417437; Tue, 28 Apr 2026 06:36:57 -0700 (PDT) Received: from [192.168.1.122] (cpc159313-cmbg20-2-0-cust161.5-4.cable.virginm.net. [82.0.78.162]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463ff5a1acsm6284374f8f.33.2026.04.28.06.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 06:36:56 -0700 (PDT) Message-ID: <0dd0c884-c846-4f17-986d-fb24b21a836f@gmail.com> Date: Tue, 28 Apr 2026 14:36:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions() To: Dan Carpenter , Alejandro Lucero Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Martin Habets , Jiri Pirko , netdev@vger.kernel.org, linux-net-drivers@amd.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-GB From: Edward Cree In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/04/2026 10:09, Dan Carpenter wrote: > Return -EINVAL if efx_mcdi_rpc() doesn't return enough space. > > Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100") > Signed-off-by: Dan Carpenter > --- > drivers/net/ethernet/sfc/efx_devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c > index d842c60dfc10..45f412bb9b5d 100644 > --- a/drivers/net/ethernet/sfc/efx_devlink.c > +++ b/drivers/net/ethernet/sfc/efx_devlink.c > @@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx, > if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) { > netif_err(efx, drv, efx->net_dev, > "mcdi MC_CMD_GET_VERSION failed\n"); > - return rc; > + return rc ?: -EINVAL; > } > > /* Handle previous output */ Usual practice in sfc is to use -EIO for 'MC response was too short'; it signifies misbehaviour from the hardware, not any invalid input argument as -EINVAL would suggest. Other than that, looks fine. -ed