public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Johannes Thumshirn <jthumshirn@suse.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@intel.com>,
	Christoph Hellwig <hch@lst.de>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 7/7] nvme: provide UUID value to userspace
Date: Tue, 30 May 2017 10:31:19 +0200	[thread overview]
Message-ID: <0dda446e-342d-49f2-8dfe-e778cfb0bc40@suse.de> (raw)
In-Reply-To: <e850e7d9548348ae46c82230a7077c89073e80f3.1496131397.git.jthumshirn@suse.de>

On 05/30/2017 10:08 AM, Johannes Thumshirn wrote:
> Now that we have a way for getting the UUID from a target, provide it
> to userspace as well.
> 
> Unfortunately there is already a sysfs attribute called UUID which is
> a misnomer as it holds the NGUID value. So instead of creating yet
> another wrong name, create a new 'nguid' sysfs attribute for the
> NGUID. For the UUID attribute add a check wheter the namespace has a
> UUID assigned to it and return this or return the NGUID to maintain
> backwards compatibility. This should give userspace a chance to catch
> up.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
>  drivers/nvme/host/core.c | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2017-05-30  8:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30  8:08 [PATCH 0/7] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-05-30  8:08 ` [PATCH 1/7] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-05-30  8:18   ` Hannes Reinecke
2017-05-30  8:08 ` [PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-05-30  8:20   ` Hannes Reinecke
2017-05-30  9:24   ` Christoph Hellwig
2017-05-30  9:48     ` Johannes Thumshirn
2017-05-31  9:45       ` Christoph Hellwig
2017-05-30  8:08 ` [PATCH 3/7] nvmet: add eui64 " Johannes Thumshirn
2017-05-30  8:21   ` Hannes Reinecke
2017-05-30  9:25   ` Christoph Hellwig
2017-05-30  9:45     ` Johannes Thumshirn
2017-05-31  9:46       ` Christoph Hellwig
2017-05-31 11:24         ` Johannes Thumshirn
2017-05-30  8:08 ` [PATCH 4/7] nvme: also report include the EUI-64 in identify NS report Johannes Thumshirn
2017-05-30  8:22   ` Hannes Reinecke
2017-05-30  9:27   ` Christoph Hellwig
2017-05-30  8:08 ` [PATCH 5/7] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-05-30  8:24   ` Hannes Reinecke
2017-05-30  8:08 ` [PATCH 6/7] nvme: get list of namespace descriptors Johannes Thumshirn
2017-05-30  8:30   ` Hannes Reinecke
2017-05-30  8:08 ` [PATCH 7/7] nvme: provide UUID value to userspace Johannes Thumshirn
2017-05-30  8:31   ` Hannes Reinecke [this message]
2017-05-30  9:30   ` Christoph Hellwig
2017-05-30 10:23     ` Johannes Thumshirn
2017-05-31  9:43 ` [PATCH 0/7] Implement NVMe Namespace Descriptor Identification Christoph Hellwig
2017-05-31 11:22   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dda446e-342d-49f2-8dfe-e778cfb0bc40@suse.de \
    --to=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox