From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751126AbdE3Ib0 (ORCPT ); Tue, 30 May 2017 04:31:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:49525 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750896AbdE3IbV (ORCPT ); Tue, 30 May 2017 04:31:21 -0400 Subject: Re: [PATCH 7/7] nvme: provide UUID value to userspace To: Johannes Thumshirn , Sagi Grimberg , Keith Busch , Christoph Hellwig Cc: Linux Kernel Mailinglist , Linux NVMe Mailinglist References: From: Hannes Reinecke Message-ID: <0dda446e-342d-49f2-8dfe-e778cfb0bc40@suse.de> Date: Tue, 30 May 2017 10:31:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2017 10:08 AM, Johannes Thumshirn wrote: > Now that we have a way for getting the UUID from a target, provide it > to userspace as well. > > Unfortunately there is already a sysfs attribute called UUID which is > a misnomer as it holds the NGUID value. So instead of creating yet > another wrong name, create a new 'nguid' sysfs attribute for the > NGUID. For the UUID attribute add a check wheter the namespace has a > UUID assigned to it and return this or return the NGUID to maintain > backwards compatibility. This should give userspace a chance to catch > up. > > Signed-off-by: Johannes Thumshirn > --- > drivers/nvme/host/core.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)