From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8288BC4332F for ; Wed, 2 Nov 2022 02:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbiKBCYs (ORCPT ); Tue, 1 Nov 2022 22:24:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbiKBCYp (ORCPT ); Tue, 1 Nov 2022 22:24:45 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EBBD6577 for ; Tue, 1 Nov 2022 19:24:44 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id p21so11405237plr.7 for ; Tue, 01 Nov 2022 19:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S7UBdmk5MbBq8xf2xERnJFzAhfjmMFD1Ky4jz35lNF8=; b=Ov3ploiPrzbeq6flPiF5LhBY7nXtGzNgcCAIY30CnXl+B32v/IR7MR9/Rr7Y5yuWlK yzO9kkalrV7/xaphq3qK7InlXhNHnVNq0gvmWKqYQsr1S3A+U5F/XTl2w9rtiOy3zn72 QhjChHTrUAzLJd39wvxVjEkG4pGXGaVaBK5U4flJlX+0boaeHtRZWOuZGTIWo+dBjlv0 it64h/ou+b/y6xcAl7s8bSFN3dLtinvtt7Fo3iRcOSBVO1DSzdGijmNgbb4LafoQvvNq yw3BWEYKEKxP9N8XKSQox7JZixChmshToPYAbDvxd9BeL5DzUEr8Aa6lKQKQTfXr4Kvd EFlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S7UBdmk5MbBq8xf2xERnJFzAhfjmMFD1Ky4jz35lNF8=; b=rqmq8LSUbLo+hzXzLi25J9AvjDkYzYtIuuI5eOiTp6KCjvXFYgTq5Qk3zPADKmH37o Zq4cwsYcT/vPqdeFQ7SjE8E4geVysYRmsgmhhUzMonyv58TqKvnKVvRTBv/RC8bSPZ6g KVAtxp6tHeB1wwZAOOugJXTTtWM9YW22APk7xdN4TC2rEAAfND9a+OYZ6lFwyVzJ3gip ivgVUubakGiAD0ZFMcsHdwgRfPfged6blh4B+T0YnXSCpdB9xAK2MWuECq+zXOA5+ghY hevOPWOTlhDcD8uhKpiyNfhDTOm6QdER5tP+Zmw0nPbD/udnxGaHOT15NPSLVPhE3aq5 j9xg== X-Gm-Message-State: ACrzQf1OBvA816bJBI/S8sb+rFu4A+uWq8ZXE/eLSNtHq33NA6mMazWt ccqsO5WMJh218g556sZMxpHw+A== X-Google-Smtp-Source: AMsMyM7f3lJIE5Nd37JDrODYmcoJXutEpbXq+qiZ6RiEAYOekxd2L2qLxa6g18v1swxU0Uu3FLNHng== X-Received: by 2002:a17:903:41cc:b0:186:b756:a5f0 with SMTP id u12-20020a17090341cc00b00186b756a5f0mr22440171ple.132.1667355884067; Tue, 01 Nov 2022 19:24:44 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id z7-20020aa79587000000b0056bb4bbfb9bsm7377584pfj.95.2022.11.01.19.24.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 19:24:43 -0700 (PDT) Message-ID: <0ddaf04b-84b5-8173-a67c-5dadce684108@kernel.dk> Date: Tue, 1 Nov 2022 20:24:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH -next v4 1/5] block, bfq: remove set but not used variable in __bfq_entity_update_weight_prio Content-Language: en-US To: Yu Kuai , jack@suse.cz, paolo.valente@linaro.org Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, "yukuai (C)" References: <20221102022542.3621219-1-yukuai1@huaweicloud.com> <20221102022542.3621219-2-yukuai1@huaweicloud.com> <7f7e59cb-e0b8-0db5-7c46-11aea963bcfa@kernel.dk> <61725ff6-6da3-3d3c-4261-7f05c57ab9da@huaweicloud.com> From: Jens Axboe In-Reply-To: <61725ff6-6da3-3d3c-4261-7f05c57ab9da@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/22 8:18 PM, Yu Kuai wrote: > Hi, > > 在 2022/11/02 10:11, Jens Axboe 写道: >> On 11/1/22 8:09 PM, Jens Axboe wrote: >>> On 11/1/22 8:25 PM, Yu Kuai wrote: >>>> From: Yu Kuai >>>> >>>> After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), >>>> the local variable 'bfqd' is not used anymore, thus remove it. >>> >>> Please add a Fixes tag. >> >> Looks like the rest were good to go, so I added it myself. > > Thanks for helping out. I'm not sure which commit id to use since the > fixed patch is not in linux-next yet, does the commit id stay the same > when the patch applied from for-6.2 to next ? linux-next shas are not stable, but since you're sending this to the linux-block list and against the block tree, that's obviously where you'd find that commit. -- Jens Axboe