From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Balbir Singh <balbirs@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Sunny Patel <nueralspacetech@gmail.com>
Cc: Zi Yan <ziy@nvidia.com>, Matthew Brost <matthew.brost@intel.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
Gregory Price <gourry@gourry.net>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page
Date: Fri, 8 May 2026 13:41:42 +0200 [thread overview]
Message-ID: <0e4e4bba-cf6a-42dd-bf7e-68438fb99cd0@kernel.org> (raw)
In-Reply-To: <6f92ad63-e601-425c-a61a-5ff929cba738@nvidia.com>
>> -unlock_abort:
>> - spin_unlock(ptl);
>> -abort:
>> +error:
>> + if (ptl)
>> + spin_unlock(ptl);
>> + if (pgtable)
>> + pte_free(vma->vm_mm, pgtable);
>> for (i = 0; i < HPAGE_PMD_NR; i++)
>> src[i] &= ~MIGRATE_PFN_MIGRATE;
>> return 0;
>>
>>
>
> The changes look good!
>
> Reviewed-by: Balbir Singh <balbirs@nvidia.com>
Do we prefer that or what we have in v3?
In case we prefer what I posted, it would be great if Sunny could send a v4!
--
Cheers,
David
prev parent reply other threads:[~2026-05-08 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260501115122.23288-1-nueralspacetech@gmail.com>
[not found] ` <20260501054416.af0ed62d635c3eb01d425e61@linux-foundation.org>
[not found] ` <24ab5ddc-11a9-40ed-90b2-1a6c68010928@kernel.org>
2026-05-07 9:38 ` [PATCH v3] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page Huang, Ying
[not found] ` <6f92ad63-e601-425c-a61a-5ff929cba738@nvidia.com>
2026-05-08 11:41 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4e4bba-cf6a-42dd-bf7e-68438fb99cd0@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=byungchul@sk.com \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=nueralspacetech@gmail.com \
--cc=rakie.kim@sk.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox