The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: mlevitsk@redhat.com
To: Jim Mattson <jmattson@google.com>, Tina Zhang <zhang_wei@open-hieco.net>
Cc: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	 kvm@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	zhouyanjing@hygon.cn,  linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] KVM: nSVM: Expose DecodeAssists to L1
Date: Mon, 06 Jul 2026 18:10:12 -0400	[thread overview]
Message-ID: <0e576fd8d8cd2ed1739cee36eba393fea7745506.camel@redhat.com> (raw)
In-Reply-To: <CALMp9eSLH7pT7X22es+AotxhRMQ1VyziWWELQu6_ZRsyuQ=xzw@mail.gmail.com>

On Tue, 2026-06-30 at 08:52 -0700, Jim Mattson wrote:
> On Mon, Jun 29, 2026 at 5:57 AM Tina Zhang <zhang_wei@open-hieco.net> wrote:
> > 
> > The SVM DecodeAssists feature is reported in CPUID
> > Fn8000_000A_EDX[7].  When available, hardware provides the length and bytes
> > of the intercepted instruction in the VMCB, allowing a hypervisor to consume
> > the decode information directly instead of re-decoding the instruction in
> > software on relevant VM-Exit paths.
> 
> DecodeAssists actually comprises four components:
> * GPR number in EXITINFO1 for MOV-CR and MOV-DR VM-exits
> * Software interrupt number in EXITINFO1 for INTn VM-exits
> * Linear address in EXITINFO1 for INVLPG[A] VM-exits
> * Guest instruction bytes and length in the VMCB for #NPF and #PF VM-exits
> 
> You only partially address the last component.
> 
Yes, and I also remember when I implemented some of the optional SVM features,
I decided not to implement this, also because of the same reason - pass-through
is easy but for all the emulated VM exits, it can be tricky to get that right.

Best regards,
	Maxim Levitsky


  reply	other threads:[~2026-07-06 22:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 12:52 [PATCH 0/2] KVM: nSVM: Expose DecodeAssists to L1 Tina Zhang
2026-06-29 12:52 ` [PATCH 1/2] KVM: nSVM: Virtualize DecodeAssists for nested guests Tina Zhang
2026-06-30 15:11   ` Jim Mattson
2026-06-29 12:52 ` [PATCH 2/2] KVM: selftests: Add nested SVM DecodeAssists test Tina Zhang
2026-06-30 15:52 ` [PATCH 0/2] KVM: nSVM: Expose DecodeAssists to L1 Jim Mattson
2026-07-06 22:10   ` mlevitsk [this message]
2026-07-07  0:01     ` Tina Zhang
2026-07-07  1:32       ` Jim Mattson
2026-07-07  2:44         ` Tina Zhang
2026-07-07  3:21           ` Sean Christopherson
2026-07-07  3:25             ` Jim Mattson
2026-07-07  3:32               ` Jim Mattson
2026-07-07 14:42                 ` Sean Christopherson
2026-07-07 15:19                   ` Jim Mattson
2026-07-07 15:47                     ` Sean Christopherson
2026-07-07 18:56                       ` Jim Mattson
2026-07-07 14:41               ` Sean Christopherson
2026-07-07 15:24                 ` Jim Mattson
2026-07-07 15:37                   ` Sean Christopherson
2026-07-07 18:23                     ` Jim Mattson
2026-07-07 19:16                       ` Sean Christopherson
2026-07-08 23:21         ` Venkatesh Srinivas
2026-07-07 22:34 ` Yosry Ahmed
2026-07-08  0:53   ` Tina Zhang
2026-07-08 14:04     ` Sean Christopherson
2026-07-08 17:47     ` Yosry Ahmed
2026-07-09  1:00       ` Tina Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e576fd8d8cd2ed1739cee36eba393fea7745506.camel@redhat.com \
    --to=mlevitsk@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    --cc=zhang_wei@open-hieco.net \
    --cc=zhouyanjing@hygon.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox