From: Krzysztof Kozlowski <krzk@kernel.org>
To: ulf.hansson@linaro.org
Cc: florian.fainelli@broadcom.com,
Shen Lichuan <shenlichuan@vivo.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com,
rafal@milecki.pl
Subject: Re: [PATCH v1] pmdomain: bcm: Convert to use dev_err_probe()
Date: Fri, 30 Aug 2024 20:13:10 +0200 [thread overview]
Message-ID: <0ea33217-321e-40e5-a2f0-77693fa7e3f0@kernel.org> (raw)
In-Reply-To: <20240830113206.5427-1-shenlichuan@vivo.com>
On 30/08/2024 13:32, Shen Lichuan wrote:
> Use dev_err_probe() to simplify the error path and unify a message
> template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
>
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
> drivers/pmdomain/bcm/bcm-pmb.c | 6 ++----
Ulf,
Since ~2 weeks there is tremendous amount of trivial patches coming from
vivo.com. I identified at least 6 buggy, where the contributor did not
understand the code. Not sure about intention, but I advise extra
carefulness when dealing with these "trivial" improvements (because we
tend to apply things which look trivial).
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-30 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 11:32 [PATCH v1] pmdomain: bcm: Convert to use dev_err_probe() Shen Lichuan
2024-08-30 18:13 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea33217-321e-40e5-a2f0-77693fa7e3f0@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=rafal@milecki.pl \
--cc=shenlichuan@vivo.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox