From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35B5944684F for ; Fri, 24 Jul 2026 21:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784927442; cv=none; b=iTVQCsVke1rUf2Eoi+fYpB9d/77bvsySQM5+sQKVE9R33OmZKK/VUuFGl7b00hC96Yi45HmMLJ3O/FcwX+eM0u38DrV/fPxuVQUsTGqEJD4CE9A8ZneXw6+qDL+7x+SS+bl4PxSIlGbU36cGgecKaLFJMcLdDP7wy/SfRUV/9aQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784927442; c=relaxed/simple; bh=80pVOvLhx+Wdn2FQlmGhXjRbHTitdSLioqC2O3ubCNg=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=auqX+RWF61hfJBVaS6fHXv/WkwKKt9AVlDchSbiRtB9HY9gGixgUVKUyFz81mt0oPiIaLl5rngJTUD5kkbAq2Qu1a9f2LtMrVsYXOfDjg+kTf7Gyc1gilvjyS2ZSYmysNzHJ35kdUfl3K0aj/v2/i7z70kE8vYyePmyH931/tac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=GsgTI+hk; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="GsgTI+hk" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-92e512a9a6bso64223285a.2 for ; Fri, 24 Jul 2026 14:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1784927440; x=1785532240; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uhsc75Oo6AuEhvOwEPNfuq0mbfOFTRMSybKBRxOVKlw=; b=GsgTI+hkHZ8VmqwdycBolYwd8MAMkyuNZF/A+K2t7KBqJqUidBRThjwV7HnfkkibJ3 msHHPvb0nmhZdhv/aRTscPRcdzMN8oeCnxagwJaEcH92q6e7hoIvhwME25JXHWLZ5TCl jR28bKTd8Lf/tx2+68pdLvrj0wGa+iTL8/J0QGnp9o4gjP/Xld9auKLLAYliAk0cC290 omly/ZMeIfggI/rX5DEGpNlWP0tZKJlOasvDJ1wVXio26fN/InyVJFwuelEqfyjxADTd lgdMOZWf7y1au3iqjPRQ7j3HgDZHROLtt5/PTfiP7lUKO6XxryOim3mOZ+dli0rgwYSx 1K5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784927440; x=1785532240; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uhsc75Oo6AuEhvOwEPNfuq0mbfOFTRMSybKBRxOVKlw=; b=mSdJIs1BhJ0YYGFTC7odB+qKtQQxL30oX8Vr4B0iQRIIyySc2VdVhmowpCeL0JcjNH 5eivbD0gWwtppLfp48l5BUByKDaogw4i6zl3HxViX7iaBlCpzWomv0md5y2VHbANfNAr YLo91ipmQuD2rHTTUpHrteCD6cy2ygW4Me5r6KbJhcQ7V/v+ZZ29CMAG/wgr1GgSTsVu vtbKZBsAJmCsZcav97FR6n9vSUWTWqYwfA0Ew0pINiv7SuWJNBYwrl6THjp9+J52kC3H K1LhjAx99acqdXh9JJe/OZR0/NCxYKtzvg/tUabUynbJcyfJz03Tzt4qVgv23kjlCzeN vi6Q== X-Forwarded-Encrypted: i=1; AHgh+Rr/aARNZhgULoWb/AVimlJIzZrqdmTXCIVBDBCLsCOi0GOG1fSpN1UHZUtU/oZE7MSDW1ui8RGzZdH/fFE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5GazlTR6i+YPq0zoDIUYbmhqvTVV7mbjbCycibMNCGwh27J7l 7bOd1iUbE8HNbGCOD2AqwHPclkmj/WGdB1ddUycbedR4Ipb+2rqFYuDtSm84V60Bjw== X-Gm-Gg: AR+sD10c8S3uw3Tt2Pcd6xmIqMmB+0DonxNCRL6rjmqAZ0MPoO8QRvn6i57raEdnzNJ fhQK/Zi8ubFp7IJbxzPTc/H6T39Tq/4fBXqkGnm75UuFfBQPRzs5/1B/p3k9F2lbeOzCPwCaIjx +EsvHLGSSUJ+ECrEq/PZgYxwEeDWFQ/gX00cgezw/UsZ5+H7lTiLGv4KfAB6xFP+f/C1D5KVM8N FlcY51hID+KllTeiS5im03bADC0FYtQITW/yktwh/ucMtQ9ps+3ws4xiju92gkXlYq0BAlCyhit DUvmBPetn5ohq4qo26b3lFITANx4lPMJwOjyfXK+JVjDRTsiSBQuEqf07smhoLZyMvh/tzzS2A9 X3wAWCATSuoWxEu/8mdGk/CaQY3leSciFvaCe0NuGnOZYPS5Eov7LFpubPn+t1ENJUCUmVQ8cTr AVW+GfyHVr/Dip6vfNBh9gdaDhMnmqryPdqn1+KszLsvCPeN0= X-Received: by 2002:a05:620a:2915:b0:92e:7ba3:740d with SMTP id af79cd13be357-93103a568cfmr1043858085a.68.1784927439959; Fri, 24 Jul 2026 14:10:39 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id af79cd13be357-932de676a41sm5540085a.46.2026.07.24.14.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 14:10:39 -0700 (PDT) Date: Fri, 24 Jul 2026 17:10:38 -0400 Message-ID: <0ea73a164fb2397e58ae28a2fa35266d@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260724_1628/pstg-lib:20260724_1535/pstg-pwork:20260724_1628 From: Paul Moore To: Jori Koolstra , Alexander Viro , Christian Brauner , Eric Paris Cc: Jan Kara , NeilBrown , linux-fsdevel@vger.kernel.org, audit@vger.kernel.org, linux-kernel@vger.kernel.org, Jori Koolstra Subject: Re: [PATCH 3/3] fs/namei.c: update kerneldoc of atomic_open() References: <20260710164233.827744-4-jkoolstra@xs4all.nl> In-Reply-To: <20260710164233.827744-4-jkoolstra@xs4all.nl> On Jul 10, 2026 Jori Koolstra wrote: > > The comments above atomic_open() contain several errors: > > - atomic_open() does not return 0 if successful > - @path is not updated > > Fix those and be more explicit about when FMODE_OPENED and FMODE_CREATED > are set. Change to a full kerneldoc. > > Signed-off-by: Jori Koolstra > --- > fs/namei.c | 32 ++++++++++++++++++++------------ > 1 file changed, 20 insertions(+), 12 deletions(-) Reviewed-by: Paul Moore -- paul-moore.com