From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207AbdK1JNH (ORCPT ); Tue, 28 Nov 2017 04:13:07 -0500 Received: from mout.web.de ([212.227.15.4]:63031 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbdK1JNB (ORCPT ); Tue, 28 Nov 2017 04:13:01 -0500 Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions To: Joe Perches , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: "Andrew F. Davis" , Arvind Yadav , Bartlomiej Zolnierkiewicz , Tomi Valkeinen , LKML , kernel-janitors@vger.kernel.org References: <1511809633.32426.70.camel@perches.com> <1511833514.32426.86.camel@perches.com> <7e7e64cf-dbe5-614a-f1e5-29d7b6cf9297@users.sourceforge.net> <1511856244.19952.14.camel@perches.com> From: SF Markus Elfring Message-ID: <0ecf4b17-7757-adb4-b978-a80ebb15cfe6@users.sourceforge.net> Date: Tue, 28 Nov 2017 10:11:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1511856244.19952.14.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:BX8ZAO7obt8z1WaOHTnWRhHlJbEswunI+rMXBLat15/g4NQgjey ncu4k5gAJAMJXCBo3yYYEWKezTX8McLXxv+d8Z1dx2Z51/3x4Kli3/XHVYhjpD/NNfPQvII KhFfZVz9MzoocZsDU/oj8FNTAgdAAVEJ+7DewRPyvDuVDydQRzpLth7hYfp9hlGxeNV8eYc dApZQYcx2ddeQd5l/30iQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:PSHPPbedal4=:scnR5qWPJ9X3MSRMkpa0bp 2PtVXmuJmy6E+bF8pErs9jOfMHxMqRvKPiIgyHnLKkYNY6RefkTK1qeJ1UvTPZlEQmmJPNzoq xy38kR/FdfOu5rZb8mPjcBuyS3O0f8gxCMPYqEatyi1ER9pDcIF3pkgTOoOfN0JHhZpHFHtvO g2cj5AhhDBXVHckPGTjzEirk7mPAV0p9SwWwvupUD1WoeM1dupb/C0VytBGQkMFf04vnBda93 F0e+sR1lO7yL3OQLugO751Lxyo3KQsU7fgidMhWSEzxon14yZJ2k78A4jD7XBBiMeBj1pLHz/ cGTTXguTaHM2QTWWRFoI3Lv3xW0/naQioaEtUFWWVGBvCz265BD87VpZlStJcxLfQFPj0pL7A ADFwEScSMLgdzRFbZURkdOhq/VTlX32WZL7c5lTWQSMpULar/InuK3EjHE1zoCb4VSef1mPhZ ieAZ/um1a2Gyr1tXr0iRNAds3kpTvGqouPpxH9TwIBgWTI0M1E2gPonQw3xNspD8KPeBDrtGs xEX2k81tBGKBPXubLdnpZzayu94YtVbRooYn/XvMNSV8cC2W03rl1VWmqSJZ1hq8IjEoKXjHh en58xXtR4wRkpsBrtIdyH4jZKBcQttTsMcvZvHs3OJhtQ6poWHh/kGjf5emQtqaLNpulWswW7 bIPPCch3irLDpmYTUPeHi07CEcY01PqAky0kFiwgY0CTlJABYOae31RBGC08OHejEgwPzgI+g 575+YEKwGfdvWNji73gMB8V0nfJsXqZg9DXk+0tqB7jdUQisK06/JLHo7XUdJBFz12EoUyOpn 3A9JnB5yLWeCFpMMfEzORXffbxl3Mpv09rbIiSII4KvYa80b8xWfWKRfxDbbEFw5VFtto/9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > How many times have I told you to include the reason for > your patches in your proposed commit message? It might be useful to look again. > Too often. I answered this feedback to some degree. > Many people do not know that a generic kmalloc does a > dump_stack() on OOM. This is another interesting information, isn't it? It is expected that the function “devm_kzalloc” has got a similar property. > That information should be part of the commit message. How do you think about to provide it also in any reference documentation in a clearer way? I would be more confident then to copy it into my messages. Do you want that I take your current answer as an official note for my work (instead of waiting for adjustments of other areas)? > Also removing the printk code reduces overall code size. Such an effect can be nice if the involved contributors can agree on the deletion of questionable error messages at all. > The actual size reduction should be described in the > commit message too. For which hardware and software combinations would you like to see facts there? Regards, Markus