From: "Colin King (gmail)" <colin.i.king@googlemail.com>
To: Denis Kirjanov <dkirjanov@suse.de>,
Colin Ian King <colin.i.king@googlemail.com>,
Jeroen de Borst <jeroendb@google.com>,
Catherine Sullivan <csully@google.com>,
David Awogbemila <awogbemila@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"
Date: Tue, 26 Oct 2021 10:34:38 +0100 [thread overview]
Message-ID: <0ed0b3bd-05ab-d357-56a3-e2ce33169030@gmail.com> (raw)
In-Reply-To: <a7155c22-c487-9a76-d3b3-628c0e27d3b0@suse.de>
On 26/10/2021 10:32, Denis Kirjanov wrote:
>
>
> 10/26/21 12:22 PM, Colin Ian King пишет:
>> There is a spelling mistake in a netdev_warn message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> you could fix the second instance as well:
Will do. Thanks for noting that :-)
>
> grep -nri droping drivers/net/
> drivers/net/wireless/mac80211_hwsim.c:1279: /* Droping until
> WARN_QUEUE level */
> drivers/net/ethernet/google/gve/gve_rx.c:441: "RX
> fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
>
>
>> ---
>> drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c
>> b/drivers/net/ethernet/google/gve/gve_rx.c
>> index c8500babbd1d..ef4aa6487c55 100644
>> --- a/drivers/net/ethernet/google/gve/gve_rx.c
>> +++ b/drivers/net/ethernet/google/gve/gve_rx.c
>> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx
>> *ctx, struct gve_rx_ring *rx)
>> if (frag_size > rx->packet_buffer_size) {
>> packet_size_error = true;
>> netdev_warn(priv->dev,
>> - "RX fragment error: packet_buffer_size=%d,
>> frag_size=%d, droping packet.",
>> + "RX fragment error: packet_buffer_size=%d,
>> frag_size=%d, dropping packet.",
>> rx->packet_buffer_size, be16_to_cpu(desc->len));
>> }
>> page_info = &rx->data.page_info[idx];
>>
next prev parent reply other threads:[~2021-10-26 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 9:22 [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping" Colin Ian King
2021-10-26 9:32 ` Denis Kirjanov
2021-10-26 9:34 ` Colin King (gmail) [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-15 22:26 Colin Ian King
2022-03-17 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed0b3bd-05ab-d357-56a3-e2ce33169030@gmail.com \
--to=colin.i.king@googlemail.com \
--cc=awogbemila@google.com \
--cc=csully@google.com \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=jeroendb@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox