* [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"
@ 2021-10-26 9:22 Colin Ian King
2021-10-26 9:32 ` Denis Kirjanov
0 siblings, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2021-10-26 9:22 UTC (permalink / raw)
To: Jeroen de Borst, Catherine Sullivan, David Awogbemila,
David S . Miller, Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
There is a spelling mistake in a netdev_warn message. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
index c8500babbd1d..ef4aa6487c55 100644
--- a/drivers/net/ethernet/google/gve/gve_rx.c
+++ b/drivers/net/ethernet/google/gve/gve_rx.c
@@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx *ctx, struct gve_rx_ring *rx)
if (frag_size > rx->packet_buffer_size) {
packet_size_error = true;
netdev_warn(priv->dev,
- "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
+ "RX fragment error: packet_buffer_size=%d, frag_size=%d, dropping packet.",
rx->packet_buffer_size, be16_to_cpu(desc->len));
}
page_info = &rx->data.page_info[idx];
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"
2021-10-26 9:22 [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping" Colin Ian King
@ 2021-10-26 9:32 ` Denis Kirjanov
2021-10-26 9:34 ` Colin King (gmail)
0 siblings, 1 reply; 5+ messages in thread
From: Denis Kirjanov @ 2021-10-26 9:32 UTC (permalink / raw)
To: Colin Ian King, Jeroen de Borst, Catherine Sullivan,
David Awogbemila, David S . Miller, Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
10/26/21 12:22 PM, Colin Ian King пишет:
> There is a spelling mistake in a netdev_warn message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
you could fix the second instance as well:
grep -nri droping drivers/net/
drivers/net/wireless/mac80211_hwsim.c:1279: /* Droping until WARN_QUEUE
level */
drivers/net/ethernet/google/gve/gve_rx.c:441: "RX fragment error:
packet_buffer_size=%d, frag_size=%d, droping packet.",
> ---
> drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
> index c8500babbd1d..ef4aa6487c55 100644
> --- a/drivers/net/ethernet/google/gve/gve_rx.c
> +++ b/drivers/net/ethernet/google/gve/gve_rx.c
> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx *ctx, struct gve_rx_ring *rx)
> if (frag_size > rx->packet_buffer_size) {
> packet_size_error = true;
> netdev_warn(priv->dev,
> - "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
> + "RX fragment error: packet_buffer_size=%d, frag_size=%d, dropping packet.",
> rx->packet_buffer_size, be16_to_cpu(desc->len));
> }
> page_info = &rx->data.page_info[idx];
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"
2021-10-26 9:32 ` Denis Kirjanov
@ 2021-10-26 9:34 ` Colin King (gmail)
0 siblings, 0 replies; 5+ messages in thread
From: Colin King (gmail) @ 2021-10-26 9:34 UTC (permalink / raw)
To: Denis Kirjanov, Colin Ian King, Jeroen de Borst,
Catherine Sullivan, David Awogbemila, David S . Miller,
Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
On 26/10/2021 10:32, Denis Kirjanov wrote:
>
>
> 10/26/21 12:22 PM, Colin Ian King пишет:
>> There is a spelling mistake in a netdev_warn message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> you could fix the second instance as well:
Will do. Thanks for noting that :-)
>
> grep -nri droping drivers/net/
> drivers/net/wireless/mac80211_hwsim.c:1279: /* Droping until
> WARN_QUEUE level */
> drivers/net/ethernet/google/gve/gve_rx.c:441: "RX
> fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
>
>
>> ---
>> drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c
>> b/drivers/net/ethernet/google/gve/gve_rx.c
>> index c8500babbd1d..ef4aa6487c55 100644
>> --- a/drivers/net/ethernet/google/gve/gve_rx.c
>> +++ b/drivers/net/ethernet/google/gve/gve_rx.c
>> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx
>> *ctx, struct gve_rx_ring *rx)
>> if (frag_size > rx->packet_buffer_size) {
>> packet_size_error = true;
>> netdev_warn(priv->dev,
>> - "RX fragment error: packet_buffer_size=%d,
>> frag_size=%d, droping packet.",
>> + "RX fragment error: packet_buffer_size=%d,
>> frag_size=%d, dropping packet.",
>> rx->packet_buffer_size, be16_to_cpu(desc->len));
>> }
>> page_info = &rx->data.page_info[idx];
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"
@ 2022-03-15 22:26 Colin Ian King
2022-03-17 2:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2022-03-15 22:26 UTC (permalink / raw)
To: Jeroen de Borst, Catherine Sullivan, David Awogbemila,
David S . Miller, Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
There is a spelling mistake in a netdev_warn warning. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
index e4e98aa7745f..021bbf308d68 100644
--- a/drivers/net/ethernet/google/gve/gve_rx.c
+++ b/drivers/net/ethernet/google/gve/gve_rx.c
@@ -439,7 +439,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx *ctx, struct gve_rx_ring *rx)
if (frag_size > rx->packet_buffer_size) {
packet_size_error = true;
netdev_warn(priv->dev,
- "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
+ "RX fragment error: packet_buffer_size=%d, frag_size=%d, dropping packet.",
rx->packet_buffer_size, be16_to_cpu(desc->len));
}
page_info = &rx->data.page_info[idx];
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"
2022-03-15 22:26 Colin Ian King
@ 2022-03-17 2:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-17 2:40 UTC (permalink / raw)
To: Colin Ian King
Cc: jeroendb, csully, awogbemila, davem, kuba, netdev,
kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 15 Mar 2022 22:26:15 +0000 you wrote:
> There is a spelling mistake in a netdev_warn warning. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [next] gve: Fix spelling mistake "droping" -> "dropping"
https://git.kernel.org/netdev/net-next/c/2fc559c8cba0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-17 2:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 9:22 [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping" Colin Ian King
2021-10-26 9:32 ` Denis Kirjanov
2021-10-26 9:34 ` Colin King (gmail)
-- strict thread matches above, loose matches on Subject: below --
2022-03-15 22:26 Colin Ian King
2022-03-17 2:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox