From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com,
hui.wang@canonical.com, srinivas.kandagatla@linaro.org,
jank@cadence.com, sanyog.r.kale@intel.com,
rander.wang@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH 2/3] soundwire: intel: add SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH quirk
Date: Mon, 1 Feb 2021 10:20:08 -0600 [thread overview]
Message-ID: <0ed1c91b-09ca-dc6f-39d1-850d12f4f9c4@linux.intel.com> (raw)
In-Reply-To: <20210201104229.GY2771@vkoul-mobl>
On 2/1/21 4:42 AM, Vinod Koul wrote:
> On 26-01-21, 16:37, Bard Liao wrote:
>> There is nothing we can do to handle the bus clash interrupt before
>> interrupt mask is enabled.
>>
>> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
>> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> ---
>> drivers/soundwire/intel.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
>> index a2d5cdaa9998..f7ba1a77a1df 100644
>> --- a/drivers/soundwire/intel.c
>> +++ b/drivers/soundwire/intel.c
>> @@ -1286,6 +1286,8 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus)
>> if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE)
>> prop->hw_disabled = true;
>>
>> + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH;
>
> Should this not be last 'enabling' the quirk patch in series :)
Sorry, I don't understand the comment. Do you mind clarifying Vinod?
next prev parent reply other threads:[~2021-02-01 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:37 [PATCH 0/3] soundwire: clear bus clash/parity interrupt before the mask is enabled Bard Liao
2021-01-26 8:37 ` [PATCH 1/3] soundwire: bus: clear bus clash " Bard Liao
2021-02-01 10:28 ` Vinod Koul
2021-02-01 10:38 ` Vinod Koul
2021-02-01 16:18 ` Pierre-Louis Bossart
2021-02-02 4:39 ` Vinod Koul
2021-02-02 16:52 ` Pierre-Louis Bossart
2021-02-03 11:03 ` Vinod Koul
2021-01-26 8:37 ` [PATCH 2/3] soundwire: intel: add SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH quirk Bard Liao
2021-02-01 10:42 ` Vinod Koul
2021-02-01 16:20 ` Pierre-Louis Bossart [this message]
2021-02-02 4:41 ` Vinod Koul
2021-02-02 16:53 ` Pierre-Louis Bossart
2021-01-26 8:37 ` [PATCH 3/3] soundwire: bus: clear parity interrupt before the mask is enabled Bard Liao
2021-02-01 11:09 ` Vinod Koul
2021-02-01 16:29 ` Pierre-Louis Bossart
2021-02-02 4:44 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed1c91b-09ca-dc6f-39d1-850d12f4f9c4@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox