From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1201A58D for ; Tue, 30 Dec 2025 00:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767055722; cv=none; b=Qnrh44IfML2fEJlU7TdWZ050czOt9BMaQSHxdTgmE6zlMGJyAdqB4OpwSEGtN8sKKa4ntQnEAnoovGONTj88M1pMhkH24z/7NpvM0MggbNIDdIWUgAJ1CcqF56pkdh/naQ0eBt6NQKzCTO5VjYSOB/M4TSPiSVL7VwEkp1RxRAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767055722; c=relaxed/simple; bh=SCav7Xh1WOgN3JTknxTrlyeaLMPfl6Q8XQZmijRLiK8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PZSjbyClkh8ILEZXtrKN6L41cft9lUCfmavH0eQfhUIAX9Z7WH1ACdI0KuIGraMR5pLM4M+2ocxlULFN2yzSw+MJBTb7jRggxCKen9JAOmsOxoSx411U8JqJC9ITN5zz3e5YJpxgr6+AgWwc/JvQj+gN3Rvlgqo13CF9+zS+ofI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=URbNJSNs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kAdzJgue; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="URbNJSNs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kAdzJgue" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BTKdaMn2723370 for ; Tue, 30 Dec 2025 00:48:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y8GM0Fp1UaT9GVrANfYfNHw8unV8Ol5iqYkldQaK+ZU=; b=URbNJSNs1znaniOK h2VcdVwdYx16hwcrs466rzvAqPmYRn8e4OB1JS1y4KtQE3Wdmh+zqo7vVN69vrvt ALGOoaPmnwmftkpCL7idkqDPExZo9PdsNu5I5JayRZ1DTGUJMp2EWqtwdcXB84V/ mTqVjISIhXXMZ3wxpa7uVPWhotA0vFkF6SRY1VbqsvVbvsrcjkVlb7jKGcAerzqY p45vMhEccR6JuLDskpgrXYig0eWipVCoBzEqaiUBstcSjLib6/zHOPGY1z5A4QAc cn+pakJFxETMGWiuHLZagxgtdyj/WmlY7SXljsqPtDm8486OEb3jt99mYEMOuwIF Q8HpiQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc0vdgbw6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 00:48:39 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7b895b520a2so10587071b3a.0 for ; Mon, 29 Dec 2025 16:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767055718; x=1767660518; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y8GM0Fp1UaT9GVrANfYfNHw8unV8Ol5iqYkldQaK+ZU=; b=kAdzJguemda6JBER8xp7WN8t/vqOphaOY9HZYyyf8vnJ+ffRE0Y0A14CJc6ZE8i4NH wh5rEXZMH5Nq5jkrHRlEP1pMigjkQ4VvqhctlXGZawavXIw0POi+OlKMBAf5jcy52nYV mn92qFHEQU7NjwoXvT0zwrm2bTRntGXD75tBYoMO15OSvBkaEtVzXtQMhLguNsSVo3g2 VWgr7dLJozhQXLhUk22Ghv7UXG1+7bGHrvXwYYHKtULa+XR1oQZj3hojpC2iz+xjdxyf 87hJ8Ee1+3ZOJmapUeFxTEv6wpNlsBWVsTZ+Xbs0sKBedTpL40LZbI0lEH3OPAUKaPYq kxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767055718; x=1767660518; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y8GM0Fp1UaT9GVrANfYfNHw8unV8Ol5iqYkldQaK+ZU=; b=EnSre5W1yT7UUNthF3q4oahvfkKvi5D8vy87EJczeHCbY6C6+wtF+HXcS/Di64X/s8 /fmDfr9SIg7uwG4qCawzfG3oR3hUgpzVEgu+c9tqcsaRNo2yfKQQ0xNaTtWTs6gYuaW+ loT4q5inEyjsUBiYXuHC0tApKy8foVVHdD6i9B9j6v5N9slwCZxdRvuLCjaNQUdOOQrB wqkyN7buhOK5uNgKIiPtzqB8OCVewPguxijZdiD3+HIo7MEMFEqE/mI+gJnuxrNTqzmB wItOYpnpOFruTWRi+K64gwO0q2FGGdWiOnj/hXfHd4Tg+DBLopDYFzdawTbQPEolIXeA H4HA== X-Forwarded-Encrypted: i=1; AJvYcCV6lirfucR8Gaxg2JRCzaM8lVIbr2Bn+DXgWW9DTTp1oxrwu6+gEQlbVPSRyKcZPhuZB7fYkYvCa4oQbeU=@vger.kernel.org X-Gm-Message-State: AOJu0YwO1CerhSwpblhJa74JRvuyLQfVPj9XnxarxCH6N8Fz/pJCY/KF Ji/mL073Up5fHg2ItHlhJ4unKdO8INmBwR3e4MW4bUt5DBEcZdlM7temZzuZsic5BW9tzdiLyXw sUfXKmEsc0E5UcriM+b0vSq6+BzaJbmJFgnsP46cQlWqU4ae+dfxsk4/u/GSlWhlJvmY= X-Gm-Gg: AY/fxX5/7RvC82stRh/Rriwcty8+5dKH89vh5AKE4KMxXE0rT5uIDTYagnCZgYBeFy8 uXocPzZLU9ozeoscicxZyRSzyi+0amrbRtIOnaSRzBJA7xegBcNwfpz/x3gtY7pv2wb8SsS1wyo U/SKe6iYqMMwRpJucSac/u2+0WTAaL8HX5k2nzNfwWFZs9aiCYeaH52Pv2TaCNd8JLdftDc51JN UaKo5Vc1MEZZte9FGuOf1deZDRZzi+9+0agLebDQjV+NIikq5TxYbXKhMg35S2+M8gQiAlkW0IF 4hD8ZmJPOecVA+PaltqTTU0l3mYHoft3hAIkUTdfoPhYLglgIc26Ghhh3GSh9PlJRyx6xwQuxf1 zg6oHOHFCZNPPyE45SqIMBULmFzhTgNjfdTZlBXHEKAJtvLjgQvfYHgYB6NpJK4vMMVLC X-Received: by 2002:a05:6a00:f9b:b0:7f6:3f21:7d22 with SMTP id d2e1a72fcca58-7ff65f768d7mr26444730b3a.45.1767055718203; Mon, 29 Dec 2025 16:48:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUtkKvhymw8Xl8ay+KCoAJfW45Qb+Ibnnd83sYZQxUa0ZEf1vevTrmAqPjGAuIFuOeLCXXdg== X-Received: by 2002:a05:6a00:f9b:b0:7f6:3f21:7d22 with SMTP id d2e1a72fcca58-7ff65f768d7mr26444718b3a.45.1767055717691; Mon, 29 Dec 2025 16:48:37 -0800 (PST) Received: from [10.133.33.5] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f26asm30025450b3a.52.2025.12.29.16.48.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 16:48:37 -0800 (PST) Message-ID: <0ed71599-e8be-4987-985e-785f2d47cf96@oss.qualcomm.com> Date: Tue, 30 Dec 2025 08:48:33 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: Commonize IQ-X-IOT DTSI To: Konrad Dybcio , Krzysztof Kozlowski , YijieYang Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251222-purwa-v1-0-14ab9316e5ff@oss.qualcomm.com> <20251222060335.3485729-3-yijie.yang@oss.qualcomm.com> <20251222-fluorescent-turkey-of-gallantry-df0906@quoll> <6421f044-2b07-4518-9edc-b9b2ef49f4fb@kernel.org> <8bcf058f-5bf9-46ce-a188-e94954101f2f@oss.qualcomm.com> <4f79d090-7d1c-4fb3-a835-a7e4ff96f79c@oss.qualcomm.com> <448f2efa-5b1e-4855-a62d-2e375938b36f@kernel.org> <19f46c69-fbfc-4129-98ae-fc5aef3f75eb@oss.qualcomm.com> <8cac29c3-6b05-479d-a06b-583f9def7beb@oss.qualcomm.com> Content-Language: en-US From: Tingwei Zhang In-Reply-To: <8cac29c3-6b05-479d-a06b-583f9def7beb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=dfONHHXe c=1 sm=1 tr=0 ts=69532167 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=-EYVSfHI5QxSVCcxwr0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDAwNCBTYWx0ZWRfX6zRzGkQdvour rmS6gl2gDbaXUZsF8x/CgE54X4edKnhaBC/QPJx6S10Z1s04PRqtZwoolIJbAnKm6f5fWwAxahD QQXm4Uw/SxWt14t8Xn0wrZjTss2N/+osJ00PyYJBm5xRWw1n8ykWSLKz6YiA9kaunLm+lDHBDpW TI50OgIW87/tJAIGnXi9HW4GGEeM8zfx1/pFdPBU70eb5TfZtQ5mglUbqzvU5RoF8myNhZj+R2f ax3F4Cix5Pm3X9IeWSGOvflfRoNC9nQ6ZkAA2cYyHiXatn02QetSpPWtzo5SWlPc99GnFo9mg+U wm5pPKD5m7B1Rc5Y2+VpDSkhzDwubkm8b6Qvj6SFfFkl8c8SqYDykiHHKPcp3wzHDOuhObtzw1w 6ecTCuC7/lGgZx4+2xKM6jIseQqJG/IBgQZnBLOPd5niTEf0JbLBdNOjlFuU3W3bxNKGSPnRPgH 2Ivols1Fy1QryGbJqwg== X-Proofpoint-GUID: AFdo4sNpcVJx0-HiVzo9PlnRMnQjMxNX X-Proofpoint-ORIG-GUID: AFdo4sNpcVJx0-HiVzo9PlnRMnQjMxNX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_07,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300004 On 12/29/2025 7:27 PM, Konrad Dybcio wrote: > On 12/29/25 11:19 AM, Tingwei Zhang wrote: >> >> On 12/29/2025 3:21 PM, Krzysztof Kozlowski wrote: >>> On 29/12/2025 02:23, Tingwei Zhang wrote: >>>> On 12/24/2025 8:12 AM, Tingwei Zhang wrote: >>>>> On 12/23/2025 9:41 PM, Krzysztof Kozlowski wrote: >>>>>> On 23/12/2025 04:38, Tingwei Zhang wrote: >>>>>>> On 12/22/2025 5:11 PM, Krzysztof Kozlowski wrote: >>>>>>>> On Mon, Dec 22, 2025 at 02:03:28PM +0800, YijieYang wrote: >>>>>>>>> From: Yijie Yang >>>>>>>>> >>>>>>>>> HAMOA-IOT-EVK and PURWA-IOT-EVK share a similar board design. Extract >>>>>>>>> the common components into separate files for better maintainability. >>>>>>>> SoMs do not share actual hardware. DTSI does not represent what looks >>>>>>>> similar to you, but actually common parts. >>>>>>> Purwa SOM board and Hamoa SOM board share same design. They share same PCB. >>>>>>> The difference is only on chip. Purwa SOM board has Purwa and Hamoa SOM board >>>>>>> has Hamoa on it.  >>>>>> I do not speak about boards. Read carefully feedback and respond to the >>>>>> actual feedback, not some other arguments. >>>>>> >>>>>> NAK >>>>> In this change, the SoM hardware except SoC is described by iq-x-iot-som.dtsi since it's common between Hamoa and Purwa. Hamoa and Purwa SoC hardware is described in hamoa.dtsi and purwa.dtsi. Hamoa-iot-som.dtsi includes iq-x-iot-som.dtsi and hamoa.dtsi. This change could reduce the duplicate code and review effort on a totally new purwa-iot-som.dtsi. If we found any bug, it can be fixed in one common file instead of two separate files. Same idea is used in x1-crd.dtsi. X1e80100-crd.dts include x1-crd.dtsi and hamoa.dtsi. >>>> Krzysztof, >>>> Please let me know your opinion on this. This could be a common case for >>>> Hamoa/Purwa boards share same PCB. Share same dtsi file like x1-crd.dtsi >>> It's not the same PCB. You did not really respond to my first message, >>> so I responded to you - I do not speak about boards. Then again you did >>> not respond to it and brought some irrelevant arguments. >>> >>>> would reduce maintenance effort. >>> Does not matter, I do not question this. Why are you responding to some >>> questions which were never asked? >>> >>> DTSI represents actual shared physical aspect and you cannot share SoM >>> physically. It's not the same PCB, because you do not have a socket on >>> the SoM. >> I didn't make myself clear enough. The SOM PCB I referred here is just the circuit >> board excluding the components on it.  Let me rephrase. >> >> Hamoa and Purwa SOM boards have very similar hardware design. They share >> same circuit board and most the components on it. The only difference is Hamoa >> SOM board has Hamoa SoC while Purwa SOM board has Purwa SoC. >> >> I agree they are not same PCB since the SoCs are different.  >> >> However, I still think it's better to use common dtsi iq-x-iot-som.dtsi since their >> hardware design is very similar.  >> >> I'll invite Konrad to chime in here as author of x1-crd.dtsi and Qualcomm SoC >> maintainer. I think we are facing similar case on purwa evk and purwa crd. >> Align to same strategy for device tree topology would be good. > Hamoa CRD vs Purwa CRD are literally a just a SoC swapped PCB as far as > I'm aware It's the same case for Hamoa IOT SOM vs Purwa IOT SOM. > Konrad