Re: [PATCH 1/2] drm/amdgpu: add the IP information of the soc

Alex Deucher
2024-03-13T20:28:40Z

On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>
> Add all the IP's information on a SOC to the
> devcoredump.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> index a0dbccad2f53..611fdb90a1fc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> @@ -196,6 +196,25 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset, size_t count,
> coredump->reset_task_info.process_name,
> coredump->reset_task_info.pid);
>
> + /* GPU IP's information of the SOC */
> + if (coredump->adev) {
> + drm_printf(&p, "\nIP Information\n");
> + drm_printf(&p, "SOC Family: %d\n", coredump->adev->family);
> + drm_printf(&p, "SOC Revision id: %d\n", coredump->adev->rev_id);
> +
> + for (int i = 0; i < coredump->adev->num_ip_blocks; i++) {
> + struct amdgpu_ip_block *ip =
> + &coredump->adev->ip_blocks[i];
> + drm_printf(&p, "IP type: %d IP name: %s\n",
> + ip->version->type,
> + ip->version->funcs->name);
> + drm_printf(&p, "IP version: (%d,%d,%d)\n\n",
> + ip->version->major,
> + ip->version->minor,
> + ip->version->rev);
> + }
> + }

I think the IP discovery table would be more useful. Either walk the
adev->ip_versions structure, or just include the IP discovery binary.

Alex

> +
> if (coredump->ring) {
> drm_printf(&p, "\nRing timed out details\n");
> drm_printf(&p, "IP Type: %d Ring Name: %s\n",
> --
> 2.34.1
>