* [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for comment
@ 2023-12-05 23:12 ` Randy Dunlap
2023-12-12 0:34 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-12-05 23:12 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Andy Gross, Bjorn Andersson, Konrad Dybcio,
MyungJoo Ham, Chanwoo Choi
Do not use "/**" for non-kernel-doc comments. This prevents a warning
from scripts/kernel-doc:
warning: expecting prototype for extcon(). Prototype was for USB_ID_DEBOUNCE_MS() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/extcon/extcon-qcom-spmi-misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-qcom-spmi-misc.c
--- a/drivers/extcon/extcon-qcom-spmi-misc.c
+++ b/drivers/extcon/extcon-qcom-spmi-misc.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
* extcon-qcom-spmi-misc.c - Qualcomm USB extcon driver to support USB ID
* and VBUS detection based on extcon-usb-gpio.c.
*
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for comment
2023-12-05 23:12 ` [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for comment Randy Dunlap
@ 2023-12-12 0:34 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2023-12-12 0:34 UTC (permalink / raw)
To: 'Randy Dunlap', linux-kernel
Cc: 'Andy Gross', 'Bjorn Andersson',
'Konrad Dybcio', 'MyungJoo Ham'
> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Wednesday, December 6, 2023 8:12 AM
> To: linux-kernel@vger.kernel.org
> Cc: Randy Dunlap <rdunlap@infradead.org>; Andy Gross <agross@kernel.org>;
> Bjorn Andersson <andersson@kernel.org>; Konrad Dybcio
> <konrad.dybcio@linaro.org>; MyungJoo Ham <myungjoo.ham@samsung.com>;
Chanwoo
> Choi <cw00.choi@samsung.com>
> Subject: [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for
> comment
>
> Do not use "/**" for non-kernel-doc comments. This prevents a warning from
> scripts/kernel-doc:
>
> warning: expecting prototype for extcon(). Prototype was for
> USB_ID_DEBOUNCE_MS() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/extcon/extcon-qcom-spmi-misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-
> qcom-spmi-misc.c
> --- a/drivers/extcon/extcon-qcom-spmi-misc.c
> +++ b/drivers/extcon/extcon-qcom-spmi-misc.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
> * extcon-qcom-spmi-misc.c - Qualcomm USB extcon driver to support USB ID
> * and VBUS detection based on extcon-usb-gpio.c.
> *
Applied it. Thanks.
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-12 0:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20231205231212epcas1p3e1fd5a1a34013c9a735947dea09ebbeb@epcas1p3.samsung.com>
2023-12-05 23:12 ` [PATCH] extcon: qcom-spmi-misc: don't use kernel-doc marker for comment Randy Dunlap
2023-12-12 0:34 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox