From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751092AbdHWVvX (ORCPT ); Wed, 23 Aug 2017 17:51:23 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:32956 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdHWVvV (ORCPT ); Wed, 23 Aug 2017 17:51:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 445EC6025C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, alex.williamson@redhat.com, linux-arm-msm@vger.kernel.org, Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1503464171-6471-1-git-send-email-okaya@codeaurora.org> <1503464171-6471-4-git-send-email-okaya@codeaurora.org> <20170823213838.GG8498@bhelgaas-glaptop.roam.corp.google.com> From: Sinan Kaya Message-ID: <0ef4c01d-75bc-17dc-8926-2f9647cfeec8@codeaurora.org> Date: Wed, 23 Aug 2017 17:51:19 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170823213838.GG8498@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/23/2017 5:38 PM, Bjorn Helgaas wrote: > If we increase the timeout, is there still value in adding the > pci_bus_wait_crs() stuff? I'm not sure there is. I agree increasing the timeout is more than enough for FLR case. However, I was considering the wait and pending functions as a utility that I can reuse towards fixing CRS in other conditions like secondary bus reset and potentially PM. I'm planning to have a CRS session in the Linux Plumbers Conference to talk about CRS use cases. I was going to follow up this series with secondary bus reset next once this goes in. I'm unable to test PM. I can't promise how I fix/test it. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.