From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DFEC433DF for ; Fri, 15 May 2020 08:19:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C54B020709 for ; Fri, 15 May 2020 08:19:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ATUAU1/w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727844AbgEOITG (ORCPT ); Fri, 15 May 2020 04:19:06 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:15601 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726716AbgEOITF (ORCPT ); Fri, 15 May 2020 04:19:05 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589530745; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=b15zrAYlQprMOsxRmwfaMv2/XJdzaN8Ceooz+8pLgE4=; b=ATUAU1/w4xQ7JghRoIZHCHWwZrO4BWmSQ1KgtDVum6z8cr0IBomqlFtssGXLv+kwER1YkOln KBppyQuOgu4qlORIFjI/fLfUtvI5CL0IdQFPSciNUFtfM5GRnVtjWfqhbMBdNd4szOGWfs5H 1fiYLE3JxHdwSsdZ3mVf7td9GOw= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5ebe506f5d62762fd4a5b18a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 15 May 2020 08:18:55 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5C29FC43637; Fri, 15 May 2020 08:18:54 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9BAE7C433D2; Fri, 15 May 2020 08:18:53 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 15 May 2020 13:48:53 +0530 From: Sibi Sankar To: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org Cc: bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, dianders@chromium.org, evgreen@chromium.org, mka@chromium.org, linux-kernel-owner@vger.kernel.org, swboyd@chromium.org Subject: Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device In-Reply-To: <20200511175532.25874-1-sibis@codeaurora.org> References: <20200511175532.25874-1-sibis@codeaurora.org> Message-ID: <0f0679f57a213536dfbba78b5c2dab5c@codeaurora.org> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Will, On 2020-05-11 23:25, Sibi Sankar wrote: > The modem remote processor has two access paths to DDR. One path is > directly connected to DDR and another path goes through an SMMU. The > SMMU path is configured to be a direct mapping because it's used by > various peripherals in the modem subsystem. Typically this direct > mapping is configured statically at EL2 by QHEE (Qualcomm's Hypervisor > Execution Environment) before the kernel is entered. > > In certain firmware configuration, especially when the kernel is > already > in full control of the SMMU, defer programming the modem SIDs to the > kernel. Let's add compatibles here so that we can have the kernel > program the SIDs for the modem in these cases. > > Signed-off-by: Sibi Sankar > --- Now that the patch is reworded can you please pick it up since its the only pending path from the series. > > V6 > * Rebased on Will's for-joerg/arm-smmu/updates > * Reword commit message and add more details [Stephen] > > drivers/iommu/arm-smmu-qcom.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iommu/arm-smmu-qcom.c > b/drivers/iommu/arm-smmu-qcom.c > index 5bedf21587a56..cf01d0215a397 100644 > --- a/drivers/iommu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm-smmu-qcom.c > @@ -17,7 +17,9 @@ static const struct of_device_id > qcom_smmu_client_of_match[] = { > { .compatible = "qcom,mdp4" }, > { .compatible = "qcom,mdss" }, > { .compatible = "qcom,sc7180-mdss" }, > + { .compatible = "qcom,sc7180-mss-pil" }, > { .compatible = "qcom,sdm845-mdss" }, > + { .compatible = "qcom,sdm845-mss-pil" }, > { } > }; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.