Re: [PATCH 4/7] dt-bindings: clock: xilinx: add description of user monitor interrupt

Rob Herring
2024-07-20T14:37:12Z

On Sat, Jul 20, 2024 at 12:01:48PM +0000, Harry Austen wrote:
> This Xilinx clocking wizard IP core outputs this interrupt signal to
> indicate when one of the four optional user clock inputs is either
> stopped, overruns, underruns or glitches.
>
> This functionality was only added from version 6.0 onwards, so restrict
> it to particular compatible strings.
>
> Signed-off-by: Harry Austen <hpausten@protonmail.com>
> ---
> .../bindings/clock/xlnx,clocking-wizard.yaml | 22 ++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> index 9d5324dc1027a..4609bb56b06b5 100644
> --- a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> +++ b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> @@ -62,17 +62,37 @@ required:
> - xlnx,speed-grade
> - xlnx,nr-outputs
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - xlnx,clocking-wizard-v6.0
> + - xlnx,versal-clk-wizard
> + then:
> + properties:
> + interrupts:
> + items:
> + - description: user clock monitor interrupt
> +
> + interrupt-names:
> + items:
> + - const: monitor

Properties need to be defined at the top-level (outside the if/then
schema), then restricted here.

> +
> additionalProperties: false
>
> examples:
> - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> clock-controller@b0000000 {
> - compatible = "xlnx,clocking-wizard";
> + compatible = "xlnx,clocking-wizard-v6.0";
> reg = <0xb0000000 0x10000>;
> #clock-cells = <1>;
> xlnx,speed-grade = <1>;
> xlnx,nr-outputs = <6>;
> clock-names = "clk_in1", "s_axi_aclk";
> clocks = <&clkc 15>, <&clkc 15>;
> + interrupts-extended = <&intc 52 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "monitor";
> };
> ...
> --
> 2.45.2
>
>