From: Stephen Boyd <sboyd@kernel.org>
To: jiping huang <huangjiping95@qq.com>, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
jiping huang <huangjiping95@qq.com>
Subject: Re: [PATCH] clk: Delete init for local variable "best_crent_rate".
Date: Tue, 27 Aug 2024 10:40:09 -0700 [thread overview]
Message-ID: <0f670049f3110f2be74f28f09e277b4e.sboyd@kernel.org> (raw)
In-Reply-To: <tencent_EC61FECEE03D06AE0D29C514581901BDFB09@qq.com>
Quoting jiping huang (2024-08-27 10:21:10)
> I'm sorry, my last submission may not expressed it clearly, and there \
> is an error delete. Therefore, I would like to generate a new patch and \
> explanations.
> Actually, it is, the local variable 'best_crent_rate' is only used in \
> line 2355 for the judgment 'best_crent_rate!=parent ->rate'. However, \
> if the "if (clk_core_can_round (core))" branch condition in line 2306 \
> is true, the value of the local variable "best_crent_rate" will be \
> updated by "best_crent_rate=req.best_crent_rate;" in line 2319, otherwise \
> it will be directly returned in the "else if" branch in line 2325 and the \
> "else" branch in line 2329.
> In summary, it is unnecessary to store the "parent ->rate" value in \
> "best_crent_rate" in line 2301.
> Thank you for your precious time!
Please read the docs on how to submit patches. Especially the part about
describing your change[1]. For example, "best_crent_rate" doesn't exist.
Also, look at other commits for guidance on how to write your commit
text. Thanks!
[1] https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
next prev parent reply other threads:[~2024-08-27 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 17:21 [PATCH] clk: Delete init for local variable "best_crent_rate" jiping huang
2024-08-27 17:40 ` Stephen Boyd [this message]
2024-08-27 18:47 ` jiping huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f670049f3110f2be74f28f09e277b4e.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=huangjiping95@qq.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox