public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: paulmck@kernel.org, rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
	rostedt@goodmis.org, Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH v3 1/4] rcutorture: Update due to x86 not supporting none/voluntary preemption
Date: Thu, 5 Mar 2026 12:53:48 -0500	[thread overview]
Message-ID: <0f6f8cde-ebd6-4f77-8eeb-51c2fcccfbba@nvidia.com> (raw)
In-Reply-To: <bfe89f6c-3b63-40c6-aa6d-5f523e3e9a31@paulmck-laptop>



On 3/4/2026 7:01 PM, Paul E. McKenney wrote:
> As of v7.0-rc1, architectures that support preemption, including x86 and
> arm64, no longer support CONFIG_PREEMPT_NONE or CONFIG_PREEMPT_VOLUNTARY.
> Attempting to build kernels with these two Kconfig options results in
> .config errors.  This commit therefore switches such rcutorture scenarios
> to CONFIG_PREEMPT_LAZY.
> 
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> 
> ---
> 
> Changes since v2:
> 
> o	Fold in c69ac5693540 ("rcutorture: Adjust scenarios for default
> 	lazy preemption")
> 
> Changes since v1:
> 
> o	Add CONFIG_PREEMPT_DYNAMIC=n in order to test non-preemptible RCU.
> 
> o	Remove CONFIG_PREEMPT_COUNT=n because it conflicts with
> 	CONFIG_PREEMPT_LAZY=y.
> 
> o	Remove some stray conflicting CONFIG_PREEMPT_LAZY=n instances.
> 
[...]
> diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE04 b/tools/testing/selftests/rcutorture/configs/rcu/TREE04
> index 34aee1acb8662..ac857d5bcb222 100644
> --- a/tools/testing/selftests/rcutorture/configs/rcu/TREE04
> +++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE04
> @@ -1,11 +1,12 @@
>  CONFIG_SMP=y
>  CONFIG_NR_CPUS=8
> +CONFIG_PREEMPT_LAZY=y
>  CONFIG_PREEMPT_NONE=n
> -CONFIG_PREEMPT_VOLUNTARY=y
> +CONFIG_PREEMPT_VOLUNTARY=n
>  CONFIG_PREEMPT=n
>  CONFIG_PREEMPT_DYNAMIC=n
> -CONFIG_PREEMPT_LAZY=n
>  #CHECK#CONFIG_TREE_RCU=y
> +#CHECK#CONFIG_PREEMPT_RCU=n

nit: Let us add this #CHECK# to the other configs you changed too? Otherwise it
is a bit confusing because it took some digging to clearly see that
PREEMPT_DYNAMIC=n and PREEMPT_LAZY=y implies CONFIG_PREEMPT_RCU=n ;-)

Otherwise, I could not find any other flaws in the approach and it makes sense, so:
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>

Boqun, you will be taking this through the 7.0-rc tree right? So that 7.0
release tests don't fail.

Also I will drop the 2 related rcutorture patches for 7.1 and rebase on top of a
7.0-rc fixes branch Boqun might be creating.

Thanks!

--
Joel Fernandes

[...]


  reply	other threads:[~2026-03-05 17:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 23:58 [PATCH 0/4] rcu: Fix lazy-preemption regression in torture-test suites Paul E. McKenney
2026-03-03 23:59 ` [PATCH 1/4] rcutorture: Update due to x86 not supporting none/voluntary preemption Paul E. McKenney
2026-03-04 17:26   ` [PATCH v2 " Paul E. McKenney
2026-03-05  0:01     ` [PATCH v3 " Paul E. McKenney
2026-03-05 17:53       ` Joel Fernandes [this message]
2026-03-05 19:08         ` Paul E. McKenney
2026-03-05 18:22       ` Boqun Feng
2026-03-05 19:06         ` Paul E. McKenney
2026-03-05 19:59           ` Boqun Feng
2026-03-05 20:11             ` Paul E. McKenney
2026-03-05 21:08               ` Boqun Feng
2026-03-05 23:24                 ` Paul E. McKenney
2026-03-03 23:59 ` [PATCH 2/4] rcuscale: " Paul E. McKenney
2026-03-03 23:59 ` [PATCH 3/4] refscale: " Paul E. McKenney
2026-03-03 23:59 ` [PATCH 4/4] scftorture: " Paul E. McKenney
2026-03-05 21:29 ` [PATCH 0/4] rcu: Fix lazy-preemption regression in torture-test suites Boqun Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f6f8cde-ebd6-4f77-8eeb-51c2fcccfbba@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=boqun.feng@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox