* [PATCH] riscv: dts: starfive: jh7110-pinfunc.h
@ 2024-12-10 1:48 E Shattow
2024-12-10 2:14 ` Hal Feng
2024-12-13 9:36 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: E Shattow @ 2024-12-10 1:48 UTC (permalink / raw)
To: Conor Dooley, Emil Renner Berthing, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Hal Feng, Jianlong Huang
Cc: E Shattow, Conor Dooley, linux-riscv, devicetree, linux-kernel
Fix a typo in StarFive JH7110 pin function definitions
Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
Signed-off-by: E Shattow <e@freeshell.de>
---
arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
index 256de17f5261..ae49c908e7fb 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
+++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
@@ -89,7 +89,7 @@
#define GPOUT_SYS_SDIO1_DATA1 59
#define GPOUT_SYS_SDIO1_DATA2 60
#define GPOUT_SYS_SDIO1_DATA3 61
-#define GPOUT_SYS_SDIO1_DATA4 63
+#define GPOUT_SYS_SDIO1_DATA4 62
#define GPOUT_SYS_SDIO1_DATA5 63
#define GPOUT_SYS_SDIO1_DATA6 64
#define GPOUT_SYS_SDIO1_DATA7 65
base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] riscv: dts: starfive: jh7110-pinfunc.h
2024-12-10 1:48 [PATCH] riscv: dts: starfive: jh7110-pinfunc.h E Shattow
@ 2024-12-10 2:14 ` Hal Feng
2024-12-10 4:09 ` E Shattow
2024-12-13 9:36 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Hal Feng @ 2024-12-10 2:14 UTC (permalink / raw)
To: E Shattow, Conor Dooley, Emil Renner Berthing, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Jianlong Huang
Cc: Conor Dooley, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
> On 10.12.24 09:49, E Shattow wrote:
> [PATCH] riscv: dts: starfive: jh7110-pinfunc.h
Describe something in the commit title?
>
> Fix a typo in StarFive JH7110 pin function definitions
>
> Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function
> definitions")
> Signed-off-by: E Shattow <e@freeshell.de>
Acked-by: Hal Feng <hal.feng@starfivetech.com>
Best regards,
Hal
> ---
> arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
> b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
> index 256de17f5261..ae49c908e7fb 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
> +++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
> @@ -89,7 +89,7 @@
> #define GPOUT_SYS_SDIO1_DATA1 59
> #define GPOUT_SYS_SDIO1_DATA2 60
> #define GPOUT_SYS_SDIO1_DATA3 61
> -#define GPOUT_SYS_SDIO1_DATA4 63
> +#define GPOUT_SYS_SDIO1_DATA4 62
> #define GPOUT_SYS_SDIO1_DATA5 63
> #define GPOUT_SYS_SDIO1_DATA6 64
> #define GPOUT_SYS_SDIO1_DATA7 65
>
> base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c
> --
> 2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] riscv: dts: starfive: jh7110-pinfunc.h
2024-12-10 2:14 ` Hal Feng
@ 2024-12-10 4:09 ` E Shattow
0 siblings, 0 replies; 4+ messages in thread
From: E Shattow @ 2024-12-10 4:09 UTC (permalink / raw)
To: Hal Feng, Conor Dooley, Emil Renner Berthing, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Jianlong Huang
Cc: Conor Dooley, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
On 12/9/24 18:14, Hal Feng wrote:
>> On 10.12.24 09:49, E Shattow wrote:
>> [PATCH] riscv: dts: starfive: jh7110-pinfunc.h
>
> Describe something in the commit title?
>
>>
>> Fix a typo in StarFive JH7110 pin function definitions
>>
>> Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function
>> definitions")
>> Signed-off-by: E Shattow <e@freeshell.de>
>
> Acked-by: Hal Feng <hal.feng@starfivetech.com>
>
> Best regards,
> Hal
>
>> ---
>> arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
>> b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
>> index 256de17f5261..ae49c908e7fb 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
>> @@ -89,7 +89,7 @@
>> #define GPOUT_SYS_SDIO1_DATA1 59
>> #define GPOUT_SYS_SDIO1_DATA2 60
>> #define GPOUT_SYS_SDIO1_DATA3 61
>> -#define GPOUT_SYS_SDIO1_DATA4 63
>> +#define GPOUT_SYS_SDIO1_DATA4 62
>> #define GPOUT_SYS_SDIO1_DATA5 63
>> #define GPOUT_SYS_SDIO1_DATA6 64
>> #define GPOUT_SYS_SDIO1_DATA7 65
>>
>> base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c
>> --
>> 2.45.2
>
Ah... yes I forgot the commit title. Will re-send. Thanks! -E
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: starfive: jh7110-pinfunc.h
2024-12-10 1:48 [PATCH] riscv: dts: starfive: jh7110-pinfunc.h E Shattow
2024-12-10 2:14 ` Hal Feng
@ 2024-12-13 9:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-13 9:36 UTC (permalink / raw)
To: E Shattow
Cc: Conor Dooley, Emil Renner Berthing, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Hal Feng, Jianlong Huang, Conor Dooley, linux-riscv, devicetree,
linux-kernel
On Mon, Dec 09, 2024 at 05:48:57PM -0800, E Shattow wrote:
> Fix a typo in StarFive JH7110 pin function definitions
That's not a "typo", but entire wrong value with actual impact.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-13 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-10 1:48 [PATCH] riscv: dts: starfive: jh7110-pinfunc.h E Shattow
2024-12-10 2:14 ` Hal Feng
2024-12-10 4:09 ` E Shattow
2024-12-13 9:36 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox