From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774AbdH2We4 (ORCPT ); Tue, 29 Aug 2017 18:34:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42706 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbdH2Wey (ORCPT ); Tue, 29 Aug 2017 18:34:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 51ADA605A5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] acpi: apei: call into AER handling regardless of severity To: Borislav Petkov , "Baicar, Tyler" , Tony Luck Cc: rjw@rjwysocki.net, lenb@kernel.org, will.deacon@arm.com, james.morse@arm.com, prarit@redhat.com, punit.agrawal@arm.com, shiju.jose@huawei.com, andriy.shevchenko@linux.intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Linux PCI References: <1503940314-29526-1-git-send-email-tbaicar@codeaurora.org> <20170829082055.u3qpwtgyzxjxfvup@pd.tnic> <9abb2e99-44be-3315-47d9-2689b6c76d79@codeaurora.org> <20170829221932.ojkvr4y6s76hcpkj@pd.tnic> From: Sinan Kaya Message-ID: <0fb1fe1b-207a-93fe-4ac6-b886451e488e@codeaurora.org> Date: Tue, 29 Aug 2017 18:34:49 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170829221932.ojkvr4y6s76hcpkj@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +linux-pci On 8/29/2017 6:19 PM, Borislav Petkov wrote: > if (entry.severity == AER_NONFATAL) > do_recovery(pdev, entry.severity); Providing input from PCI perspective only: PCIe defines the the following error categories: 1. Correctable error 2. Uncorrectable non-fatal errors 3. Uncorrectable fatal errors The do_recovery function needs to be called for both uncorrectable error categories. (#2 and #3 above) How these map to GHES error categories is out of know-how. Below are references to some of the PCIe error docs: https://www.kernel.org/doc/Documentation/PCI/pcieaer-howto.txt https://www.kernel.org/doc/Documentation/PCI/pci-error-recovery.txt -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.