The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Donald Robson <Donald.Robson@imgtec.com>
To: Frank Binns <Frank.Binns@imgtec.com>,
	Matt Coster <Matt.Coster@imgtec.com>,
	"arnd@kernel.org" <arnd@kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>
Cc: "tzimmermann@suse.de" <tzimmermann@suse.de>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"maarten.lankhorst@linux.intel.com" 
	<maarten.lankhorst@linux.intel.com>,
	Sarah Walker <Sarah.Walker@imgtec.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>
Subject: Re: [EXTERNAL] Re: [PATCH 2/2] drm/imagination: avoid -Woverflow warning
Date: Wed, 29 Nov 2023 12:15:31 +0000	[thread overview]
Message-ID: <0ff259983bd8ae6edc434b3375bfea871aa8ed65.camel@imgtec.com> (raw)
In-Reply-To: <d4d42b22-076b-4980-aa43-d5458a094873@app.fastmail.com>

On Wed, 2023-11-29 at 13:04 +0100, Arnd Bergmann wrote:
> *** CAUTION: This email originates from a source not known to Imagination Technologies. Think before you click a link or open an attachment ***
> 
> On Wed, Nov 29, 2023, at 13:01, Donald Robson wrote:
> > Hello Arnd,
> > 
> > Thanks for the patch.  I'm slightly concerned that we've not seen this 
> > warning when
> > building here.  I guess we need to check our CI settings...
> > 
> > Reviewed-by: Donald Robson <donald.robson@imgtec.com>
> 
> This was previously enabled only when building with either
> "make W=1" or "make C=1", but not the default build, which
> explains why it only showed up after the merge into linux-next
> that has the corresponding scripts/Makefile.extrawarn change.
> 
> It would still be a good idea to add the extra compiler (W=1)
> and sparse (C=1) warnings in your CI system and address all
> other issues that might uncover.
> 
>       Arnd

Thanks Arnd, we will do this.

  reply	other threads:[~2023-11-29 12:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 11:33 [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings Arnd Bergmann
2023-11-29 11:33 ` [PATCH 2/2] drm/imagination: avoid -Woverflow warning Arnd Bergmann
2023-11-29 12:01   ` Donald Robson
2023-11-29 12:04     ` Arnd Bergmann
2023-11-29 12:15       ` Donald Robson [this message]
2023-11-29 12:07 ` [PATCH 1/2] drm/imagination: avoid -Wmissing-prototype warnings Donald Robson
2023-11-29 12:16   ` Arnd Bergmann
2023-11-29 12:21     ` [EXTERNAL] " Donald Robson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ff259983bd8ae6edc434b3375bfea871aa8ed65.camel@imgtec.com \
    --to=donald.robson@imgtec.com \
    --cc=Frank.Binns@imgtec.com \
    --cc=Matt.Coster@imgtec.com \
    --cc=Sarah.Walker@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox