Re: [PATCH 3/8] netpoll: e1000 netpoll tweak

John Ronciak
2005-08-12T19:02:06Z

Sorry this reply was to go to the whole list but only made it to Matt.

The e1000_intr() routine already calls e1000_clean_tx_irq(). So
what's the point of this patch? Am I missing something?

On 8/11/05, Matt Mackall <mpm@selenic.com> wrote:
> Suggested by Steven Rostedt, matches his patch included in e100.
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>
>
> Index: l/drivers/net/e1000/e1000_main.c
> ===================================================================
> --- l.orig/drivers/net/e1000/e1000_main.c 2005-08-06 17:36:32.000000000 -0500
> +++ l/drivers/net/e1000/e1000_main.c 2005-08-06 17:55:01.000000000 -0500
> @@ -3789,6 +3789,7 @@ e1000_netpoll(struct net_device *netdev)
> struct e1000_adapter *adapter = netdev_priv(netdev);
> disable_irq(adapter->pdev->irq);
> e1000_intr(adapter->pdev->irq, netdev, NULL);
> + e1000_clean_tx_irq(adapter);
> enable_irq(adapter->pdev->irq);
> }
> #endif
>
>

--
Cheers,
John