AGPGART for AMD 761 broken in 2.4.10-pre12?

AGPGART for AMD 761 broken in 2.4.10-pre12?

[DevilKin]

Hello All,

First off, I'd like to say a big 'thank you!!!!' to all the people here, I 
was very amazed at the quickness the support for the chipset was integrated 
into the maintream kernel.

I've been testing the latest kernels a bit, and I've found out that when 
using the pre12 kernel, I once again get:

Linux agpgart interface v0.99 (c) Jeff Hartmann
agpgart: Maximum main memory to use for agp memory: 439M
agpgart: Unsupported AMD chipset (device id: 700e), you might want to try 
agp_try_unsupported=1.
agpgart: no supported devices found.

where as with the pre11 kernel it was:

Linux agpgart interface v0.99 (c) Jeff Hartmann
agpgart: Maximum main memory to use for agp memory: 439M
agpgart: Detected AMD 761 chipset


I've not had the time to crosscheck what actually changed with -pre12, but 
could it be the patch got lost somewhere?

Thanks,

DevilKin

-- 
devilkin@gmx.net

Re: AGPGART for AMD 761 broken in 2.4.10-pre12?

[DevilKin]

On Thursday 20 September 2001 19:14, DevilKin wrote:
> Hello All,
>
> First off, I'd like to say a big 'thank you!!!!' to all the people here, I
> was very amazed at the quickness the support for the chipset was integrated
> into the maintream kernel.
>
> I've been testing the latest kernels a bit, and I've found out that when
> using the pre12 kernel, I once again get:
>
> Linux agpgart interface v0.99 (c) Jeff Hartmann
> agpgart: Maximum main memory to use for agp memory: 439M
> agpgart: Unsupported AMD chipset (device id: 700e), you might want to try
> agp_try_unsupported=1.
> agpgart: no supported devices found.
>
> where as with the pre11 kernel it was:
>
> Linux agpgart interface v0.99 (c) Jeff Hartmann
> agpgart: Maximum main memory to use for agp memory: 439M
> agpgart: Detected AMD 761 chipset
>
>
> I've not had the time to crosscheck what actually changed with -pre12, but
> could it be the patch got lost somewhere?
>
> Thanks,
>
> DevilKin

I've manually applied the patch written for the pre-11 kernels, and then it 
works great. Could it be it hasn't been added to pre-12?

Thanks,

DevilKin
-- 
devilkin@gmx.net

Re: AGPGART for AMD 761 broken in 2.4.10-pre12?

[Robert Love]

On Thu, 2001-09-20 at 13:28, DevilKin wrote:
> I've manually applied the patch written for the pre-11 kernels, and then it 
> works great. Could it be it hasn't been added to pre-12?

It looks like my patch was unmerged in 2.4.10-pre12, as Linus merged the
AGP GART code from Alan's tree which does not yet have AMD 761 support. 
The patch for Alan is pending and hopefully will be in the next -ac.

Applying the 2.4.10-pre11 patch should half apply (the config entries
are still there, and some of the header code, but not the main detection
stuff), but that would work.

I am rediffing a patch (and some other minor cleanup) for 2.4.10-pre12
and I will send it to Linus.  I will CC you and the list.

-- 
Robert M. Love
rml at ufl.edu
rml at tech9.net

[PATCH] Re: AGPGART for AMD 761 broken in 2.4.10-pre12?

[Robert Love]

On Thu, 2001-09-20 at 13:14, DevilKin wrote:
> First off, I'd like to say a big 'thank you!!!!' to all the people here, I 
> was very amazed at the quickness the support for the chipset was integrated 
> into the maintream kernel.

You are welcome :)

> I've been testing the latest kernels a bit, and I've found out that when 
> using the pre12 kernel, I once again get: <snip>

It looks like Linus merged the AGP GART from Alan's tree, which did not
yet have my AMD 761 patch, however it was more recent otherwise.  The
following patch merges in what was removed. It also provides some
cleanup.

Linus, please apply to restore the unmerged AMD 761 code.


diff -urN linux-2.4.10-pre12/Documentation/Configure.help linux/Documentation/Configure.help
--- linux-2.4.10-pre12/Documentation/Configure.help	Thu Sep 20 13:32:23 2001
+++ linux/Documentation/Configure.help	Thu Sep 20 13:33:42 2001
@@ -2578,10 +2578,10 @@
   the GLX component for XFree86 3.3.6, which can be downloaded from
   http://utah-glx.sourceforge.net/ .
 
-AMD Irongate support
+AMD Irongate, 761, and 762 support
 CONFIG_AGP_AMD
   This option gives you AGP support for the GLX component of the
-  XFree86 4.x on AMD Irongate and 761 chipsets.
+  XFree86 4.x on AMD Irongate, 761, and 762 chipsets.
 
   For the moment, you should probably say N, unless you want to test
   the GLX component for XFree86 3.3.6, which can be downloaded from
diff -urN linux-2.4.10-pre12/drivers/char/Config.in linux/drivers/char/Config.in
--- linux-2.4.10-pre12/drivers/char/Config.in	Thu Sep 20 13:31:44 2001
+++ linux/drivers/char/Config.in	Thu Sep 20 13:34:03 2001
@@ -208,7 +208,7 @@
    bool '  Intel 440LX/BX/GX and I815/I840/I850 support' CONFIG_AGP_INTEL
    bool '  Intel I810/I815 (on-board) support' CONFIG_AGP_I810
    bool '  VIA chipset support' CONFIG_AGP_VIA
-   bool '  AMD Irongate and 761 support' CONFIG_AGP_AMD
+   bool '  AMD Irongate, 761, and 762 support' CONFIG_AGP_AMD
    bool '  Generic SiS support' CONFIG_AGP_SIS
    bool '  ALI chipset support' CONFIG_AGP_ALI
    bool '  Serverworks LE/HE support' CONFIG_AGP_SWORKS
diff -urN linux-2.4.10-pre12/drivers/char/agp/agp.h linux/drivers/char/agp/agp.h
--- linux-2.4.10-pre12/drivers/char/agp/agp.h	Thu Sep 20 13:31:44 2001
+++ linux/drivers/char/agp/agp.h	Thu Sep 20 13:35:12 2001
@@ -202,6 +202,9 @@
 #ifndef PCI_DEVICE_ID_AMD_IRONGATE_0
 #define PCI_DEVICE_ID_AMD_IRONGATE_0    0x7006
 #endif
+#ifndef PCI_DEVICE_ID_AMD_761_0
+#define PCI_DEVICE_ID_AMD_761_0         0x700e
+#endif
 #ifndef PCI_DEVICE_ID_AMD_762_0
 #define PCI_DEVICE_ID_AMD_762_0		0x700C
 #endif
diff -urN linux-2.4.10-pre12/drivers/char/agp/agpgart_be.c linux/drivers/char/agp/agpgart_be.c
--- linux-2.4.10-pre12/drivers/char/agp/agpgart_be.c	Thu Sep 20 13:31:44 2001
+++ linux/drivers/char/agp/agpgart_be.c	Thu Sep 20 13:37:26 2001
@@ -388,8 +388,8 @@
  * Driver routines - start
  * Currently this module supports the following chipsets:
  * i810, i815, 440lx, 440bx, 440gx, i840, i850, via vp3, via mvp3,
- * via kx133, via kt133, amd irongate, amd 761, ALi M1541, and generic
- * support for the SiS chipsets.
+ * via kx133, via kt133, amd irongate, amd 761, amd 762, ALi M1541,
+ * and generic support for the SiS chipsets.
  */
 
 /* Generic Agp routines - Start */
@@ -2931,9 +2931,15 @@
 		"AMD",
 		"Irongate",
 		amd_irongate_setup },
+	{ PCI_DEVICE_ID_AMD_761_0,
+		PCI_VENDOR_ID_AMD,
+		AMD_761,
+		"AMD",
+		"761",
+		amd_irongate_setup },
 	{ PCI_DEVICE_ID_AMD_762_0,
 		PCI_VENDOR_ID_AMD,
-		AMD_IRONGATE,
+		AMD_762,
 		"AMD",
 		"AMD 760MP",
 		amd_irongate_setup },
diff -urN linux-2.4.10-pre12/include/linux/agp_backend.h linux/include/linux/agp_backend.h
--- linux-2.4.10-pre12/include/linux/agp_backend.h	Thu Sep 20 13:31:33 2001
+++ linux/include/linux/agp_backend.h	Thu Sep 20 13:37:23 2001
@@ -59,6 +59,7 @@
 	AMD_GENERIC,
 	AMD_IRONGATE,
 	AMD_761,
+	AMD_762,
 	ALI_M1541,
 	ALI_M1621,
 	ALI_M1631,



-- 
Robert M. Love
rml at ufl.edu
rml at tech9.net