From: Robert Love <rml@tech9.net>
To: Jesper Juhl <juhl@eisenstein.dk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] various minor cleanups against 2.4.13-pre3 - comments requested
Date: 16 Oct 2001 17:34:34 -0400 [thread overview]
Message-ID: <1003268078.868.26.camel@phantasy> (raw)
In-Reply-To: <3BCC8C88.58BBCC39@eisenstein.dk>
In-Reply-To: <3BCC8C88.58BBCC39@eisenstein.dk>
On Tue, 2001-10-16 at 15:37, Jesper Juhl wrote:
> init/main.c : parse_options()
> The check that adds "line" to either "envp_init" or "argv_init"
> checks to see if the buffers are full and break;s the while() loop
> if _either_ buffer is full - it should use continue; so both buffers can
> get a chance to fill up. Robert M. Love should get credit for finding
> this one, I found it by looking at an old patch of his, and I just checked
> to see if it was still there and read the code to see if it was correct.
Thanks for running with this.
Now, for the love of all things holy, can _someone_ either tell me what
is wrong with this patch or merge it already? I originally wrote this
for 2.2!
It seems clear to me that we lose either the environment vars or
command-line args when the other one fills up...
Robert Love
next prev parent reply other threads:[~2001-10-16 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-16 19:37 [PATCH] various minor cleanups against 2.4.13-pre3 - comments requested Jesper Juhl
2001-10-16 19:52 ` Dave Jones
2001-10-16 20:24 ` [PATCH] various minor cleanups against 2.4.13-pre3 - commentsrequested Jesper Juhl
2001-10-16 19:59 ` [PATCH] various minor cleanups against 2.4.13-pre3 - comments requested Christoph Hellwig
2001-10-16 20:28 ` Jesper Juhl
2001-10-16 21:34 ` Robert Love [this message]
2001-10-17 9:13 ` Martin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1003268078.868.26.camel@phantasy \
--to=rml@tech9.net \
--cc=juhl@eisenstein.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox