public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtrr compile fix when no procfs/devfs
@ 2001-10-27  4:18 Robert Love
  0 siblings, 0 replies; only message in thread
From: Robert Love @ 2001-10-27  4:18 UTC (permalink / raw)
  To: alan; +Cc: rgooch, linux-kernel

arch/i386/kernel/mtrr.c does not compile when neither CONFIG_PROC_FS and
CONFIG_DEVFS_FS are set.  mtrr has interfaces that are defined when
either are set.

The problem is that both devfs_handle and struct mtrr_fops are declared
inside the section of code for these interfaces, but are referenced
outside of them.

Note that yes, the devfs code does not need to be explicitly ifdef'ed
since it is all defined as nops.  But then we would have to pull out the
devfs_handle typedef and mtrr_fops struct, which is just as pointless.

The attached is against 2.4.13-ac2.  Alan, please apply.


diff -ur linux-2.4.13-ac2/arch/i386/kernel/mtrr.c linux/arch/i386/kernel/mtrr.c
--- linux-2.4.13-ac2/arch/i386/kernel/mtrr.c	Fri Oct 26 15:48:14 2001
+++ linux/arch/i386/kernel/mtrr.c	Sat Oct 27 00:04:09 2001
@@ -2249,9 +2249,11 @@
 	proc_root_mtrr->proc_fops = &mtrr_fops;
     }
 #endif
+#ifdef CONFIG_DEVFS_FS
     devfs_handle = devfs_register (NULL, "cpu/mtrr", DEVFS_FL_DEFAULT, 0, 0,
 				   S_IFREG | S_IRUGO | S_IWUSR,
 				   &mtrr_fops, NULL);
+#endif
     init_table ();
     return 0;
 }   /*  End Function mtrr_init  */


	Robert Love


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-10-27  4:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-10-27  4:18 [PATCH] mtrr compile fix when no procfs/devfs Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox