From: Robert Love <rml@tech9.net>
To: Sven Vermeulen <sven.vermeulen@rug.ac.be>, torvalds@transmeta.com
Cc: Linux-Kernel Development Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: 2.4.14-pre3: some compilerwarnings...
Date: 27 Oct 2001 13:16:23 -0400 [thread overview]
Message-ID: <1004202984.3274.53.camel@phantasy> (raw)
In-Reply-To: <20011027185158.A5848@Zenith.starcenter>
In-Reply-To: <20011027185158.A5848@Zenith.starcenter>
On Sat, 2001-10-27 at 12:51, Sven Vermeulen wrote:
> A little grep on the stdout/stderr of "make bzImage":
You can't do much about unused variables because, as you suggested, they
may be present with a different config. For example, the unused
attach_it label in super.c is used if NFS is defined.
As for the typecast error, we should fix that...the attached patch uses
the typed min system macro. Linus, the attached is against
2.4.14-pre3. Please, apply.
diff -u linux-2.4.14-pre3/drivers/char/random.c linux/drivers/char/random.c
--- linux-2.4.14-pre3/drivers/char/random.c Sat Oct 27 13:13:03 2001
+++ linux/drivers/char/random.c Sat Oct 27 13:13:52 2001
@@ -1245,8 +1245,9 @@
if (r->entropy_count < nbytes * 8 &&
r->entropy_count < r->poolinfo.POOLBITS) {
- int nwords = min(r->poolinfo.poolwords - r->entropy_count/32,
- sizeof(tmp) / 4);
+ int nwords = min_t(int,
+ r->poolinfo.poolwords - r->entropy_count/32,
+ sizeof(tmp) / 4);
DEBUG_ENT("xfer %d from primary to %s (have %d, need %d)\n",
nwords * 32,
Robert Love
next prev parent reply other threads:[~2001-10-27 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-27 16:51 2.4.14-pre3: some compilerwarnings Sven Vermeulen
2001-10-27 17:16 ` Robert Love [this message]
2001-10-27 17:30 ` [PATCH] " Robert Love
2001-10-31 17:12 ` Ragnar Hojland Espinosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1004202984.3274.53.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sven.vermeulen@rug.ac.be \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox