public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: Manik Raina <manik@cisco.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: query about use of IFDEFS
Date: 02 Nov 2001 16:30:18 -0500	[thread overview]
Message-ID: <1004736618.6141.25.camel@phantasy> (raw)
In-Reply-To: <3BE2A153.B9B06FD2@cisco.com>
In-Reply-To: <3BE2A153.B9B06FD2@cisco.com>

On Fri, 2001-11-02 at 08:36, Manik Raina wrote:
> which of the following be acceptable  in the linux kernel ?
> [...]

The first.  You want the code itself to be clean and clear; free of
ifdefs.

So in your header files you ifdef as needed.  The simplest example of
this would be with a define:

	#ifdef CONFIG_SMP
	#define special_smp_thing() whatever_smp()
	#else
	#define special_smp_thing()
	#endif

	Robert Love


      reply	other threads:[~2001-11-02 21:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-02 13:36 query about use of IFDEFS Manik Raina
2001-11-02 21:30 ` Robert Love [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1004736618.6141.25.camel@phantasy \
    --to=rml@tech9.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manik@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox