From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: Keith Owens <kaos@ocs.com.au>, linux-kernel@vger.kernel.org
Subject: Re: 2.4.14 errors on full build - Y
Date: 06 Nov 2001 00:22:37 -0500 [thread overview]
Message-ID: <1005024157.1506.2.camel@phantasy> (raw)
In-Reply-To: <17526.1005022179@ocs3.intra.ocs.com.au>
In-Reply-To: <17526.1005022179@ocs3.intra.ocs.com.au>
On Mon, 2001-11-05 at 23:49, Keith Owens wrote:
> Doing a full build of 2.4.14 (everything set to Y where possible), got
> the usual collection of errors. Some of these errors have been around
> for weeks, any chance of them getting fixed?
> [...]
> drivers/mtd/chips/jedec_probe.o: In function `jedec_probe_init':
> drivers/mtd/chips/jedec_probe.o(.text.init+0x0): multiple definition of `jedec_probe_init'
> drivers/mtd/chips/jedec.o(.text.init+0x0): first defined here
Another simple fix...the multiple function declarations should be
static. Even better, a lot of the duplication between the driver should
be shared but that I shall leave as an exercises for the maintainer.
Until then, Linus, please apply.
diff -urN linux-2.4.14/drivers/mtd/chips/jedec.c linux/drivers/mtd/chips/jedec.c
--- linux-2.4.14/drivers/mtd/chips/jedec.c Mon Nov 5 20:11:15 2001
+++ linux/drivers/mtd/chips/jedec.c Tue Nov 6 00:19:15 2001
@@ -873,7 +873,7 @@
}
}
-int __init jedec_probe_init(void)
+static int __init jedec_probe_init(void)
{
register_mtd_chip_driver(&jedec_chipdrv);
return 0;
diff -urN linux-2.4.14/drivers/mtd/chips/jedec_probe.c linux/drivers/mtd/chips/jedec_probe.c
--- linux-2.4.14/drivers/mtd/chips/jedec_probe.c Mon Nov 5 20:11:15 2001
+++ linux/drivers/mtd/chips/jedec_probe.c Tue Nov 6 00:19:16 2001
@@ -422,7 +422,7 @@
module: THIS_MODULE
};
-int __init jedec_probe_init(void)
+static int __init jedec_probe_init(void)
{
register_mtd_chip_driver(&jedec_chipdrv);
return 0;
Robert Love
next prev parent reply other threads:[~2001-11-06 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-06 4:49 2.4.14 errors on full build - Y Keith Owens
2001-11-06 5:16 ` [PATCH] " Robert Love
2001-11-06 5:22 ` Robert Love [this message]
2001-11-06 14:56 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1005024157.1506.2.camel@phantasy \
--to=rml@tech9.net \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox