public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: Mike Fedyk <mfedyk@matchmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Modutils can't handle long kernel names
Date: 09 Nov 2001 00:40:12 -0500	[thread overview]
Message-ID: <1005284413.1209.2.camel@phantasy> (raw)
In-Reply-To: <20011108212328.B514@mikef-linux.matchmail.com>
In-Reply-To: <20011108204210.A514@mikef-linux.matchmail.com>  <20011108212328.B514@mikef-linux.matchmail.com>

On Fri, 2001-11-09 at 00:23, Mike Fedyk wrote:
> I've gotten into the habbit of adding the names of the patches I add to my
> kernel to the extraversion string in the top level Makefile in my kernels.

Everything in-kernel is going to be OK because we set the version string
like so:

	char version[] = UTS_RELEASE;

where UTS_RELEASE is set from the variables in your Makefile.  Thus, the
string is set to the exact size of your version on compile.  If you find
anywhere _inside the kernel_ that breaks with long strings, it is
probably a bug.

Userspace is a different story.  In general, most programs probably do
not have dynamic off-the-heap storage for the version string size. 
Added such a feature may be advantageous in some cases, but in many it
is overkill and not worth the dynamic memory management.

I would consider the case where a large string crashes a user space
program a bug.  While the program may choose to set some limit, it
should certainly check its buffers.  I would also consider an abnormally
small legal string size a bug, but I honestly don't see your version
size fitting that description. :)

Anyhow, if you want to change it in a given app, its a simple size that
needs to be changed and then recompile.

	Robert Love


  reply	other threads:[~2001-11-09  5:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-09  4:42 Modutils can't handle long kernel names Mike Fedyk
2001-11-09  5:23 ` Mike Fedyk
2001-11-09  5:40   ` Robert Love [this message]
2001-11-09  5:34 ` Keith Owens
2001-11-09 22:23   ` andersg
2001-11-10  4:29     ` Keith Owens
2001-11-14 22:04       ` Thomas Dodd
2001-11-14 22:25         ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1005284413.1209.2.camel@phantasy \
    --to=rml@tech9.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfedyk@matchmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox