From: Yang Shi <yang.shi@linux.alibaba.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
gregkh@linuxfoundation.org, tglx@linutronix.de,
dave.hansen@intel.com, stable@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] madvise05 leads kernel panic on 4.9.122
Date: Tue, 21 Aug 2018 14:32:00 -0700 [thread overview]
Message-ID: <10053bf2-3041-5262-8327-3c0254e8d211@linux.alibaba.com> (raw)
In-Reply-To: <20180821203631.GU12066@tassilo.jf.intel.com>
On 8/21/18 1:36 PM, Andi Kleen wrote:
> On Tue, Aug 21, 2018 at 01:30:20PM -0700, yang.shi@linux.alibaba.com wrote:
>>
>> On 8/21/18 11:43 AM, David Woodhouse wrote:
>>> On Tue, 2018-08-21 at 11:37 -0700, Yang Shi wrote:
>>>> I just ran some regression test on stable 4.9.122 with LTP. madvise05
>>>> triggers the below kernel panic:
>> Thanks, David. It works. A silly question, I don't get why this commit could
>> solve this issue, it looks just like a code refactor. Just because it
>> changed how to get pfn from page table entries? And, this may cause some
>> mismatch on 4.9 stable without it?
> With the L1TF patches open coded pte_val() to get the PFN can cause problems
> because it doesn't do the invert for PROT_NONE mappings
>
> The cleanup changes the open coded versions to use p*_pfn(), which always
> works correctly.
Thanks. Got it.
>
> -Andi
prev parent reply other threads:[~2018-08-21 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 18:37 [BUG] madvise05 leads kernel panic on 4.9.122 Yang Shi
2018-08-21 18:43 ` David Woodhouse
2018-08-21 20:30 ` Yang Shi
2018-08-21 20:36 ` Andi Kleen
2018-08-21 21:32 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10053bf2-3041-5262-8327-3c0254e8d211@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox